Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jinho] Week 2 #763

Merged
merged 1 commit into from
Dec 22, 2024
Merged

[jinho] Week 2 #763

merged 1 commit into from
Dec 22, 2024

Conversation

neverlish
Copy link
Contributor

@neverlish neverlish commented Dec 22, 2024

답안 제출 문제

  • Valid Anagram #218
  • Climbing Stairs #230
  • 3Sum #241
  • Construct Binary Tree From Preorder And Inorder Traversal #253
  • Decode Ways #268

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@neverlish neverlish requested a review from eunhwa99 December 22, 2024 04:27
@neverlish neverlish requested a review from a team as a code owner December 22, 2024 04:27
@github-actions github-actions bot added the go label Dec 22, 2024
Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트까지 작성해주신 점 정말 좋으셨고 고생많으셨습니다! 다만 다음번에는 한 문제푼 것이라도 PR을 먼저 열어두시면 더 리뷰를 받을 수 있을 것 같습니다!


println("YO")

if len(result1) != 2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert를 사용하는 대신에 이런식으로 테스트를 작성해도 깔끔하군요..!

@SamTheKorean SamTheKorean merged commit cc98766 into DaleStudy:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants