Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HerrineKim] Week 3 #797

Merged
merged 4 commits into from
Dec 28, 2024
Merged

[HerrineKim] Week 3 #797

merged 4 commits into from
Dec 28, 2024

Conversation

HerrineKim
Copy link
Contributor

@HerrineKim HerrineKim commented Dec 27, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HerrineKim HerrineKim requested a review from a team as a code owner December 27, 2024 13:30
@github-actions github-actions bot added the js label Dec 27, 2024
@HerrineKim HerrineKim requested a review from sungjinwi December 27, 2024 13:31
Copy link
Contributor

@sungjinwi sungjinwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제들 모두 깔끔하게 잘 푸신거 같습니다! 고생하셨어요

Comment on lines +1 to +2
// 시간 복잡도 : O(n^2)
// 공간 복잡도 : O(n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 달레코드 풀이 보고 풀었는데 재귀 함수는 시간복잡도 및 공간복잡도 계산이 다르더라구요! 한번 참고해보시면 좋을 것 같습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nums 전체를 set로 만들어놓고 확인하는게 아니라 compliment가 없는 경우에만 set에 넣고 확인하는 방식으로 하셨군요!
좋은 풀이 배워갑니다~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 리뷰 감사합니다!!

@HerrineKim HerrineKim merged commit 7682aad into DaleStudy:main Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants