Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amplitude features #1201

Merged
merged 8 commits into from
Sep 29, 2024
Merged

Adding amplitude features #1201

merged 8 commits into from
Sep 29, 2024

Conversation

himanshudube97
Copy link
Contributor

  • added page titles to clearly separate page titles.
  • added a flag ist4dmember to seperate internal users.
  • for dynamic query params (different tokens) as in login, resetpassword, invitations, added a function to make the event unique.
  • issue with getting undefined session as a prop solved -> getting session using useSession hook.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.87%. Comparing base (b81221c) to head (227caf9).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
...TransformWorkflow/FlowEditor/Components/Canvas.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1201      +/-   ##
==========================================
- Coverage   70.87%   70.87%   -0.01%     
==========================================
  Files          90       90              
  Lines        6655     6658       +3     
  Branches     1589     1616      +27     
==========================================
+ Hits         4717     4719       +2     
+ Misses       1901     1822      -79     
- Partials       37      117      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 marked this pull request as draft September 24, 2024 15:38
@himanshudube97 himanshudube97 marked this pull request as ready for review September 28, 2024 18:17
@himanshudube97 himanshudube97 removed the request for review from fatchat September 28, 2024 18:17
@himanshudube97
Copy link
Contributor Author

@Ishankoradia please can you review and merge it before releasing the code today.

@Ishankoradia Ishankoradia merged commit c9b2d91 into main Sep 29, 2024
4 of 5 checks passed
@Ishankoradia Ishankoradia deleted the adding-amplitude-features branch September 29, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants