-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding amplitude features #1201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
himanshudube97
commented
Sep 22, 2024
- added page titles to clearly separate page titles.
- added a flag ist4dmember to seperate internal users.
- for dynamic query params (different tokens) as in login, resetpassword, invitations, added a function to make the event unique.
- issue with getting undefined session as a prop solved -> getting session using useSession hook.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 70.87% 70.87% -0.01%
==========================================
Files 90 90
Lines 6655 6658 +3
Branches 1589 1616 +27
==========================================
+ Hits 4717 4719 +2
+ Misses 1901 1822 -79
- Partials 37 117 +80 ☔ View full report in Codecov by Sentry. |
@Ishankoradia please can you review and merge it before releasing the code today. |
Ishankoradia
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.