Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky (pre-commit) added. #1243

Closed
wants to merge 9 commits into from
Closed

Conversation

himanshudube97
Copy link
Contributor

@himanshudube97 himanshudube97 commented Sep 29, 2024

  1. Implemented Husky to add a pre-commit hook in Git.
  2. On every commit the staged files will be automatically formatted based on the configuration in the .prettier.json file.
  3. To format whole codebase use npm run format.

@himanshudube97 himanshudube97 self-assigned this Sep 29, 2024
@himanshudube97 himanshudube97 linked an issue Sep 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 63.16508% with 270 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (c9b2d91) to head (972aa17).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Connections/CreateConnectionForm.tsx 40.00% 35 Missing and 1 partial ⚠️
.../Components/OperationPanel/Forms/UnpivotOpForm.tsx 47.45% 25 Missing and 6 partials ⚠️
...ow/FlowEditor/Components/OperationConfigLayout.tsx 17.64% 14 Missing ⚠️
...or/Components/OperationPanel/Forms/PivotOpForm.tsx 47.82% 12 Missing ⚠️
src/components/Connections/Connections.tsx 68.75% 10 Missing ⚠️
src/components/Flows/FlowCreate.tsx 47.05% 9 Missing ⚠️
...formWorkflow/FlowEditor/Components/ProjectTree.tsx 30.76% 9 Missing ⚠️
src/components/DBT/DBTTaskList.tsx 46.66% 7 Missing and 1 partial ⚠️
...TransformWorkflow/FlowEditor/Components/Canvas.tsx 46.66% 8 Missing ⚠️
src/components/DBT/DBTTransformType.tsx 30.00% 6 Missing and 1 partial ⚠️
... and 40 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   69.47%   70.00%   +0.53%     
==========================================
  Files          97       97              
  Lines        6967     6727     -240     
  Branches     1690     1564     -126     
==========================================
- Hits         4840     4709     -131     
+ Misses       2087     1897     -190     
- Partials       40      121      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 marked this pull request as draft October 2, 2024 07:26
@himanshudube97
Copy link
Contributor Author

  • closing this pr without merging. A new Pr was raised for the same task.

@himanshudube97 himanshudube97 deleted the formatter-precommit-husky-setup branch October 4, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant