Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column exclusion logic for renaming columns not working correctly #1271

Conversation

himanshudube97
Copy link
Contributor

@himanshudube97 himanshudube97 commented Oct 16, 2024

  1. Added a disableCondition, which checks that theAdd column buttonremains disable
    1.1. If the user has not completely filled the previous fields i.e. the current name dropdown and the new name input
    1.2 If the number of columns to be renamed equals total number of columns available to be renamed.

The above condition disables the Enter key also. Enter key also works the same as Add Column button.

  1. Lines 152-155 ensure that if ALL the columns have already been renamed, the user will no longer see options to select or rename columns when editing.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (c66717b) to head (0b33b33).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...onents/OperationPanel/Forms/RenameColumnOpForm.tsx 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   71.20%   71.21%           
=======================================
  Files          97       97           
  Lines        6703     6712    +9     
  Branches     1509     1467   -42     
=======================================
+ Hits         4773     4780    +7     
- Misses       1901     1903    +2     
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit bd5f053 into main Oct 17, 2024
3 checks passed
@fatchat fatchat deleted the 1257-column-exclusion-logic-for-renaming-columns-not-working-correctly branch October 17, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column Exclusion Logic for renaming columns not working correctly
2 participants