-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUBY_ENGINE Specific Suggestions? #13
Comments
Thnx for the kind words. First of all, I'm not sure if this will work with JRuby :) DId you test it if it works? Since all the suggestions are from the fast-ruby, I would suggest that this is applied to that repo and than make the appropriate changes here. @JuanitoFatas what do you think? |
Sorry I'm not familiar with JRuby. What are your suggestions regarding |
Well, it "works", but it tells me to use a block instead of https://travis-ci.org/JuanitoFatas/fast-ruby/jobs/69644640#L259
This is the right place. The idea is that Hopefully the version/rules pairing can be generated automatically from Travis's benchmark-ips output. And the code modified to use a Chain-of-responsibility like pattern for rule resolution/lookup. |
Ok, please invest some time in making the rules automatically generated from Travis output and create a pull request where we can see this. I'm up for making Fasterer work with JRuby and creating better and automatic support. |
Having Travis drive the benchmarks is ideal, though my initial investigation shows that there may be issues. benchmark-ips can output JSON and Travis' logs are available via their API. But... this assumes that:
Unless we have a bucket, sounds sketchy. Thoughts? I'll continue to investigate. |
Of course benchmark-ips text output could be extracted from the travis logs. Makes things easier on the config side, but may be fragile. |
Okay, my conclusion is that's best to forget about using Travis CI and generate the rules file locally via |
Sorry, what's |
It allows one to run a program against various ruby installations:
Here are the docs: https://rvm.io/set/do |
Hi, very nice program here 👍. Just started using it and, being very familiar with the fast-ruby benchmarks, I thought that I would be nice to have
RUBY_ENGINE
specific suggestions.I know you have your disclaimer -and certainly we should not blindly do whatever the machine tells us, but in the case of JRuby (maybe others) some of the suggestions are counterintuitive to what most people think is "fast ruby". Tailoring suggestions for the platform could be very helpful.
Thoughts?
The text was updated successfully, but these errors were encountered: