Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash#update() vs Hash#[]= #92

Merged

Conversation

manjunath724
Copy link

Hash#update is an alias for Hash#merge!
Ergo, the suggestions for Hash#update should be similar to Hash#merge!

Ref #82

Link to Fast-Ruby PR : fastruby/fast-ruby#195

@DamirSvrtan
Copy link
Owner

Let me know once the Fast Ruby PR merges in, and we can then continue on!

@hlascelles
Copy link
Contributor

It was merged last April 👍

Keen for a merge please!

@ManjunathPrakash
Copy link

@DamirSvrtan Fast Ruby PR was merged, can we please merge this PR too? Thank you in advance.

@DamirSvrtan DamirSvrtan merged commit fb0f02c into DamirSvrtan:master Jan 25, 2024
@DamirSvrtan
Copy link
Owner

I have merged it, and I might have done it without thinking this through enough! I have realized though how many issues this might cause, as update is such a commonly used method name in Ruby world (especially in Active Record).

Before I cut a new version of fasterer with this update, @manjunath724, @hlascelles, can you all chime in a bit with your thoughts on whether this will clash a bit too much and produce false positives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants