Hash#update() vs Hash#[]= #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know once the Fast Ruby PR merges in, and we can then continue on! |
|
It was merged last April 👍 Keen for a merge please! |
|
@DamirSvrtan Fast Ruby PR was merged, can we please merge this PR too? Thank you in advance. |
|
I have merged it, and I might have done it without thinking this through enough! I have realized though how many issues this might cause, as update is such a commonly used method name in Ruby world (especially in Active Record). Before I cut a new version of fasterer with this update, @manjunath724, @hlascelles, can you all chime in a bit with your thoughts on whether this will clash a bit too much and produce false positives? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash#update is an alias for Hash#merge!
Ergo, the suggestions for Hash#update should be similar to Hash#merge!
Ref #82
Link to Fast-Ruby PR : fastruby/fast-ruby#195