Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with DelaunayTriangulation.jl v1.0 #28

Closed
asinghvi17 opened this issue Apr 30, 2024 · 6 comments
Closed

Compatibility with DelaunayTriangulation.jl v1.0 #28

asinghvi17 opened this issue Apr 30, 2024 · 6 comments

Comments

@asinghvi17
Copy link
Contributor

It seems like NaturalNeighbours is not currently compatible with DelaunayTriangulation v1. Is this a sufficiently easy refactor that I could try to do it?

@DanielVandH
Copy link
Owner

Oh, I somehow completely forgot to come back to this. I believe it should be pretty easy if you want to give it a go - this package did depend on some internals of DelaunayTriangulation.jl but hopefully they are still around. If it ends up being a bit of a problem though let me know and I'll try and do it when I have some time (or just ask me if you need assistance).

@DanielVandH
Copy link
Owner

@asinghvi17 Were you able to go through with this? I will do it now otherwise.

@asinghvi17
Copy link
Contributor Author

Haven't yet had the time unfortunately :(

@DanielVandH
Copy link
Owner

Not a problem. I will work on this today. Do you want me to ping you once I've done it incase you're waiting on it?

@asinghvi17
Copy link
Contributor Author

That would be great, thanks! I CC'ed you on the TopoPlots PR that this would probably depend on (at least for Makie v0.20.10 compat) as well.

@DanielVandH
Copy link
Owner

I've now updated the package and registered the new version @asinghvi17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants