Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows colon fix #42

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Windows colon fix #42

merged 4 commits into from
Oct 18, 2023

Conversation

Dankoy
Copy link
Owner

@Dankoy Dankoy commented Oct 18, 2023

Description

Fixed issue when creating file on windows with colons. Colons replaced with hyphen.

Fixes #41

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Export db. Expect to save file with name without colons but with hyphens in time (HH-mm-ss).

Test Configuration:

  • Firmware version: MacOS 14
  • Hardware: Macbook M1 Pro
  • SDK: jdk-17.0.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Dankoy Dankoy added the bug Something isn't working label Oct 18, 2023
@Dankoy Dankoy self-assigned this Oct 18, 2023
Copy link
Owner Author

@Dankoy Dankoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Dankoy Dankoy merged commit 29a2835 into main Oct 18, 2023
1 check passed
@Dankoy Dankoy deleted the windows-colon-fix branch October 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Windows Illegal char :
1 participant