Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option for only updating the dynmap at server start #1767

Closed
dmccoystephenson opened this issue Dec 28, 2023 · 0 comments · Fixed by #1768
Closed

Add config option for only updating the dynmap at server start #1767

dmccoystephenson opened this issue Dec 28, 2023 · 0 comments · Fixed by #1768
Assignees
@dmccoystephenson
Labels
feature
Milestone
5.3.0

Comments

@dmccoystephenson
Copy link
Member

Is your feature request related to a problem? Please describe.
Updating the dynmap all of the time causes lag. One way to help this pain point would be to only update the dynmap upon server start.

Describe the solution you'd like
A config option for only updating the dynmap upon server start should be added. If set to true, all updates except for the initial one will not be run.

Describe alternatives you've considered
No alternatives considered.

Additional context
Was mentioned as an alternative in #1766
@dmccoystephenson dmccoystephenson added this to the 5.3.0 milestone Dec 28, 2023
@dmccoystephenson dmccoystephenson self-assigned this Dec 28, 2023
@dmccoystephenson dmccoystephenson mentioned this issue Dec 28, 2023
Open
@dmccoystephenson dmccoystephenson mentioned this issue Dec 31, 2023
Merged
@dmccoystephenson dmccoystephenson linked a pull request Dec 31, 2023 that will close this issue
Config Option - Only Render Territories Upon Startup #1768
Merged
dmccoystephenson added a commit that referenced this issue Jan 3, 2024
@dmccoystephenson
Config Option - Only Render Territories Upon Startup (#1768)
aa06235 
## Problem
Rendering territories is causing a lot of lag for some servers.

## Solution
This PR introduces a config option to prevent the rendering of
territories after the initial startup of the server. This limits the lag
spike to one instance per session.

## Testing
This was used by a server owner in the community and their TPS improved
from 15 to 18. This seems to ease the lag a bit.

## Related Issues
closes #1767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmccoystephenson dmccoystephenson

Labels
feature
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Config Option - Only Render Territories Upon Startup Dans-Plugins/Medieval-Factions
1 participant
@dmccoystephenson