Old Claim Commands Deprecation (Phase 2) #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renbinden
requested changes
May 28, 2023
src/main/kotlin/com/dansplugins/factionsystem/command/faction/MfFactionCommand.kt
Outdated
Show resolved
Hide resolved
…ation # Conflicts: # src/main/resources/lang/lang_de_DE.properties # src/main/resources/lang/lang_en_GB.properties # src/main/resources/lang/lang_en_US.properties # src/main/resources/lang/lang_fr_FR.properties
renbinden
requested changes
Jun 21, 2023
| @@ -1066,6 +1066,9 @@ CommandFactionAddMemberUnknownNewPlayerFaction=Unbekanntes neues Mitglied | |||
| CommandFactionAddMemberSuccess=Dieser Spieler ist jetzt Mitglied der angegebenen Fraktion. | |||
| CommandFactionHelpAddMember=/faction addmember <player> <faction> - F�gt zwangsweise ein Mitglied zu einer Fraktion hinzu. | |||
| CommandFactionRoleSetPermissionCannotModifyRolePermissionToModifyOwnRolePermission=Du kannst die Berechtigung deiner Rolle nicht �ndern, um die Berechtigungen deiner eigenen Rolle zu �ndern. | |||
| DeprecationWarningAutoclaim=Warnung: Die automatische Anspruchsfunktion wird in einer zuk�nftigen Version entfernt. Verwenden Sie stattdessen /f claim auto. | |||
There was a problem hiding this comment.
Maybe 'Achtung' over 'Warnung', also use impolite form (everything else uses 'du')
Pass this by our translators maybe?
There was a problem hiding this comment.
I had Copilot generate these when usually I use Google Translate. That probably explains the discrepancy.
There was a problem hiding this comment.
I've posted this in the translator chat.
Google Translate suggested the following:
DeprecationWarningAutoclaim=Befehl veraltet. Verwenden Sie stattdessen /fclaim auto.
DeprecationWarningFillclaim=Befehl veraltet. Verwenden Sie stattdessen /f Claim Fill.
DeprecationWarningCheckclaim=Befehl veraltet. Verwenden Sie stattdessen die Anspruchsprüfung /f.
There was a problem hiding this comment.
What about:
DeprecationWarningAutoclaim=Befehl veraltet. Verwendest du stattdessen /f claim auto.
DeprecationWarningFillclaim=Befehl veraltet. Verwendest du stattdessen /f claim fill.
DeprecationWarningCheckclaim=Befehl veraltet. Verwendest du stattdessen /f claim check.
There was a problem hiding this comment.
Sounds good to me!
There was a problem hiding this comment.
Your suggested translations have been implemented :)
dmccoystephenson
deleted the
deprecation/claim-commands-phase-2-deprecation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the old claim commands show the deprecation warning and not execute anything.
closes #1646