Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed power insufficiency check #1785

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

dmccoystephenson
Copy link
Member

Problem

When a faction has 0 power and 1 claim, they cannot be conquered.

Solution

The power insufficiency check has been modified to use 'less than or equals' instead of 'less than'.

Testing

This was tested locally using the project's Dockerfile to spin up a container.

Relevant Issue

Closes #1730

@dmccoystephenson dmccoystephenson merged commit b842b77 into develop Jul 13, 2024
1 check passed
@dmccoystephenson dmccoystephenson deleted the power/fix-power-insufficiency-check branch July 13, 2024 04:08
@dmccoystephenson dmccoystephenson restored the power/fix-power-insufficiency-check branch July 13, 2024 04:09
@dmccoystephenson dmccoystephenson deleted the power/fix-power-insufficiency-check branch November 9, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix power insufficiency check not working properly when a faction attempts to conquer land.
1 participant