Implemented the connection protocol receiving (#532)

DarkWanderer · Oct 8, 2024 · 2b27fb2 · 2b27fb2
1 parent 4dd1179
commit 2b27fb2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/ClickHouse.Client.Tests/ConnectionTests.cs b/ClickHouse.Client.Tests/ConnectionTests.cs
@@ -193,6 +193,17 @@ public void ShouldExcludePasswordFromRedactedConnectionString()
         Assert.That(conn.RedactedConnectionString, Is.Not.Contains($"Password={MOCK}"));
     }
 
+    [Test]
+    [TestCase("https")]
+    [TestCase("http")]
+    public void ShouldSaveProtocolAtConnectionString(string protocol)
+    {
+        string protocolPart = $"Protocol={protocol}";
+        string connString = new ClickHouseConnectionStringBuilder(protocolPart).ToString();
+        using var conn = new ClickHouseConnection(connString);
+        Assert.That(conn.ConnectionString, Contains.Substring(protocolPart));
+    }
+
     [Test]
     public async Task ShouldPostDynamicallyGeneratedRawStream()
     {

diff --git a/ClickHouse.Client/ADO/ClickHouseConnection.cs b/ClickHouse.Client/ADO/ClickHouseConnection.cs
@@ -384,6 +384,7 @@ internal ClickHouseConnectionStringBuilder ConnectionStringBuilder
                 Database = database,
                 Username = username,
                 Password = password,
+                Protocol = serverUri?.Scheme,
                 Host = serverUri?.Host,
                 Port = (ushort)serverUri?.Port,
                 Compression = UseCompression,