Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] Incompability with Endergetic Expansion #3

Open
GrigLog opened this issue Jan 30, 2022 · 6 comments
Open

[1.16] Incompability with Endergetic Expansion #3

GrigLog opened this issue Jan 30, 2022 · 6 comments

Comments

@GrigLog
Copy link

GrigLog commented Jan 30, 2022

EE overrides vanilla dragon nest and makes it 1 block higher. EE tweaks vanilla code to make the egg spawn 1 block higher, but your codee does not and 2+ eggs dont spawn.
Solution: change the code to

World world = event.getEntity().getEntityWorld();
BlockPos pos = world.getHeight(Heightmap.Type.MOTION_BLOCKING, EndPodiumFeature.END_PODIUM_LOCATION);
while (world.getBlockState(pos).getBlock() != Blocks.AIR) pos.up();
world.setBlockState(pos, Blocks.DRAGON_EGG.getDefaultState());

@GrigLog
Copy link
Author

GrigLog commented Jan 30, 2022

Screenshot_238
nest 4 blocks height instead of vanilla 3

@Darkere
Copy link
Owner

Darkere commented Jan 30, 2022

BlockPos pos = world.getHeight(Heightmap.Type.MOTION_BLOCKING, EndPodiumFeature.END_PODIUM_LOCATION);

This gets the topmost empty position at that location. I don't think moving the block higher would help?

@GrigLog
Copy link
Author

GrigLog commented Jan 30, 2022

BlockPos pos = world.getHeight(Heightmap.Type.MOTION_BLOCKING, EndPodiumFeature.END_PODIUM_LOCATION);

This gets the topmost empty position at that location. I don't think moving the block higher would help?

It gets the topmost position for vanilla generation. EE replaces bedrock blocks with its own (and it does it very strange, because, for example, when you delete DIM1 folder and let The End generate second time, it generates without the nest (?!?)).
And Ive just built this code and tested with EE, it works.

@Darkere
Copy link
Owner

Darkere commented Jan 30, 2022

Hmm it might only see full blocks.

@GitJhopa
Copy link

GitJhopa commented Jul 9, 2023

  • no working in 1.19.2

@GitJhopa
Copy link

BlockPos pos = world.getHeight(Heightmap.Type.MOTION_BLOCKING, EndPodiumFeature.END_PODIUM_LOCATION);
This gets the topmost empty position at that location. I don't think moving the block higher would help?

It gets the topmost position for vanilla generation. EE replaces bedrock blocks with its own (and it does it very strange, because, for example, when you delete DIM1 folder and let The End generate second time, it generates without the nest (?!?)). And Ive just built this code and tested with EE, it works.

give please 1.19.2 Forge worked build

Thelnfamous1 added a commit to Thelnfamous1/moredragoneggs that referenced this issue Sep 1, 2023
…ng GrigLog's fix as well as extending the DragonEggMixin to apply to EE's EndergeticDragonFightManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants