Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes the rain that wasn't particle weather and some other things #1244

Merged
merged 10 commits into from
Dec 15, 2024

Conversation

lavillastrangiato
Copy link
Contributor

@lavillastrangiato lavillastrangiato commented Dec 13, 2024

About The Pull Request

  • The old rain would proc on top of the particle rain and it rained more often than the British isles. This no longer happens.
  • If you're on fire, rainstorms will extinguish mobs. If it's a gentle rain, they reduce mob fire stacks.
  • Rain now properly fills reagent containers! Thank you, makes bottles and such collect water if uncovered in the rain Vanderlin-Tales-Of-Wine/Vanderlin#265.
  • Also deletes some weather events, like acid rain, the floor is lava, and rad storms.
  • Fixes a typo. It's "eligible", not "elligble".

Why It's Good For The Game

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@NPC1314 NPC1314 added the Scheduled for testmerge This PR should be testmerged label Dec 14, 2024
@NPC1314 NPC1314 merged commit 33026ae into Darkrp-community:main Dec 15, 2024
7 checks passed
@NPC1314 NPC1314 removed the Scheduled for testmerge This PR should be testmerged label Dec 15, 2024
@lavillastrangiato lavillastrangiato deleted the rainraingoaway branch December 19, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants