-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Town Houses, Inn & Mercenary Guild #1261
Town Houses, Inn & Mercenary Guild #1261
Conversation
The roof without a second floor, with the large house, there is a stone wall on the roof above the wall instead of a roof tile, maybe misplaced? |
I haven't actually touched that. I believe it's just supposed to be a chimney. You can see them on multiple rooves 1z level above hearths. |
Alright I see, no worries then. |
/obj/structure/mineral_door/wood/fancywood{ | ||
name = "mercenary guild"; | ||
locked = 1; | ||
lockid = mercenary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find out this "mercenary guild" fancy wood door, and modify its lockid
var to be between quotation marks to identify it as a string rather than a variable (Should be "mercenary"
, not just mercenary
). Mapdiffbot is throwing an error out of this. Once it's fixed, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing it out, I fixed it for a few other doors too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, sensible use of available, unused space, and all compiles as well.
About The Pull Request
Why It's Good For The Game
It adds the Mercenary Guild building, a lounge to the Inn and 4 new towner houses which are currently missing in Stonehamlet.
Pre-Merge Checklist