Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Change password functionality. #7

Open
mrhappyasthma opened this issue Nov 5, 2016 · 3 comments · May be fixed by #30
Open

[Feature Request] Change password functionality. #7

mrhappyasthma opened this issue Nov 5, 2016 · 3 comments · May be fixed by #30
Assignees
@TeoTwawki

Comments

@mrhappyasthma
Copy link

mrhappyasthma commented Nov 5, 2016 •
edited
Loading

There is currently no way to change passwords with xiloader (to my knowledge). Could this be implemented?
@mrhappyasthma mrhappyasthma changed the title [Feature Request [Feature Request] Change password functionality. Nov 5, 2016
@TeoTwawki TeoTwawki self-assigned this Feb 11, 2018
@mrhappyasthma
Copy link
Author

I have some code ready to implement this. Requires a change in Darkstar login code first.

@mrhappyasthma mrhappyasthma mentioned this issue Jan 12, 2020
Open
mrhappyasthma added a commit to mrhappyasthma/xiloader that referenced this issue Jan 12, 2020
@mrhappyasthma
Add a change password option to xiloader.
93077b8 
This works by using the same login flow from before to validate the
correct user. However instead of returning to connect to the game
server, the user is prompted for a new password to set.

I tested all code paths manually: error cases and succesful password
changing cases.

fixed DarkstarProject#7
mrhappyasthma added a commit to mrhappyasthma/xiloader that referenced this issue Jan 12, 2020
@mrhappyasthma
Add a change password option to xiloader.
1ced4ec 
This works by using the same login flow from before to validate the
correct user. However instead of returning to connect to the game
server, the user is prompted for a new password to set.

I tested all code paths manually: error cases and succesful password
changing cases.

fixed DarkstarProject#7
mrhappyasthma added a commit to mrhappyasthma/xiloader that referenced this issue Jan 12, 2020
@mrhappyasthma
Add a change password option to xiloader.
6360501 
This works by using the same login flow from before to validate the
correct user. However instead of returning to connect to the game
server, the user is prompted for a new password to set.

I tested all code paths manually: error cases and succesful password
changing cases.

fixed DarkstarProject#7
@TeoTwawki
Copy link
Member

same. I added an email reset feature but have not had time to work out a crashbug in lobby I caused when adding it in (I derped the packet) I'll message you later on github so we can combine efforts

@mrhappyasthma
Copy link
Author

Discussed via Discord. Seems a lot of the old code was lost over the years.

However this file is currently in need of a refactor anyway, so I filed separate feature request issues for the email address creation/modification. In the meantime we can work towards making this file more maintainable and then just implement that from scratch.

@mrhappyasthma mrhappyasthma mentioned this issue Feb 23, 2020
Merged
2 tasks
mrhappyasthma added a commit to mrhappyasthma/xiloader that referenced this issue Mar 25, 2020
@mrhappyasthma
Add a change password option to xiloader.
be4c833 
This works by using the same login flow from before to validate the
correct user. However instead of returning to connect to the game
server, the user is prompted for a new password to set.

I tested all code paths manually: error cases and succesful password
changing cases.

fixed DarkstarProject#7
@topaz-next-bot topaz-next-bot mentioned this issue Dec 17, 2020
Closed
2 tasks
@mrhappyasthma mrhappyasthma linked a pull request Feb 14, 2021 that will close this issue
Open
zach2good referenced this issue in LandSandBoat/xiloader Dec 13, 2021
@mrhappyasthma @zach2good
Add a change password option to xiloader.
3a40655 
This works by using the same login flow from before to validate the
correct user. However instead of returning to connect to the game
server, the user is prompted for a new password to set.

I tested all code paths manually: error cases and succesful password
changing cases.

fixed #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeoTwawki TeoTwawki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a change password option to xiloader. mrhappyasthma/xiloader
2 participants
@mrhappyasthma @TeoTwawki