Skip to content

Commit

Permalink
Fixes target _blank redirects
Browse files Browse the repository at this point in the history
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
  • Loading branch information
DarshitChanpura committed Aug 9, 2024
1 parent 9b74854 commit ff7b043
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion public/apps/configuration/panels/auth-view/auth-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function AuthView(props: AppDependencies) {
iconType: 'popout',
iconSide: 'right',
type: 'button',
// target: "_blank"
target: '_blank',
},
];

Expand Down
2 changes: 1 addition & 1 deletion public/apps/configuration/panels/get-started.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export function GetStarted(props: AppDependencies) {
iconType: 'popout',
iconSide: 'right',
type: 'button',
// target: "_blank"
target: '_blank',
},
];
return (
Expand Down
1 change: 0 additions & 1 deletion public/apps/configuration/panels/role-list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ export function RoleList(props: AppDependencies) {
iconSide: 'left',
type: 'button',
testId: 'create-role',
// target: "_blank"
},
];
const descriptionData = [
Expand Down
4 changes: 0 additions & 4 deletions public/apps/configuration/panels/role-view/role-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,6 @@ export function RoleView(props: RoleViewProps) {
href: buildHashUrl(ResourceType.roles, Action.edit, props.roleName),
type: 'button',
fill: true,
// target: "_blank"
},
];
const roleButtons = [
Expand All @@ -427,22 +426,19 @@ export function RoleView(props: RoleViewProps) {
type: 'button', // this should be icon, but icons current do not support a border currently
testId: 'delete',
ariaLabel: 'delete',
// target: "_blank"
},
{
label: 'Duplicate',
isLoading: false,
href: duplicateRoleLink,
type: 'button',
// target: "_blank"
},
{
label: 'Edit role',
isLoading: false,
href: buildHashUrl(ResourceType.roles, Action.edit, props.roleName),
fill: true,
type: 'button',
// target: "_blank"
},
];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,6 @@ export function ManageTab(props: AppDependencies) {
run: () => showEditModal('', Action.create, ''),
type: 'button',
fill: true,
// target: "_blank"
},
];
/* eslint-disable */
Expand Down
1 change: 0 additions & 1 deletion public/apps/configuration/panels/user-list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ export function UserList(props: AppDependencies) {
iconSide: 'left',
type: 'button',
testId: 'create-user',
// target: "_blank"
},
];
const descriptionData = [
Expand Down

0 comments on commit ff7b043

Please sign in to comment.