Optionally use rollup counts SQL instead of Dataflow job for GroupItems entity group. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjennison-work
approved these changes
Sep 16, 2024
dexamundsen
approved these changes
Sep 16, 2024
dexamundsen
merged commit aad1c7d
into
mm-use-source-id-pairs-table-for-group-items-relationship
8 checks passed
dexamundsen
deleted the
mm-use-rollup-counts-sql-instead-of-dataflow-job
branch
dexamundsen
added a commit
that referenced
this pull request
Sep 16, 2024
) * Optionally use source id-pairs table for GroupItems relationship. * Move isSourceTable method into base IndexTable class. * Optionally use rollup counts SQL instead of Dataflow job for GroupItems entity group. (#1006) * Optionally use rollup counts SQL instead of Dataflow job for GroupItems entity group. * Add SZRollupCounts to annotation processor list of classes. --------- Co-authored-by: Dexter Amundsen <dexamundsen@verily.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config property
rollupCountsSqlforGroupItemstype entity groups. Default is null, matching existing behavior. When specified the indexer does not use Dataflow to compute rollup counts in theWriteRollupCountsjob. Instead it reads it directly from the specified query.It would be good to support this config property for all entity groups, not just for this specific relationship in a single entity group type. However, this is the only change could help support variant search, so we can plan to do the larger, more correct & comprehensive change in follow-on PRs.
The
aouCT_testonly/variantPersonentity group is currently the only config that specifies this property. Manually tested indexing this group and confirmed that the Dataflow job doesn't run.