Empty entity group criteria should match any occurrences #1009
+84
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjennison-work
force-pushed
the
tj-empty
branch
from
26ccebf
to
b9059d5
Compare
dexamundsen
approved these changes
Sep 16, 2024
| @@ -629,7 +628,13 @@ void criteriaWithAttrAndInstanceLevelAndGroupByModifiersCohortFilter() { | |||
|
|
|||
| @Test | |||
| void emptyCriteriaCohortFilter() { | |||
| CFEntityGroup.EntityGroup config = CFEntityGroup.EntityGroup.newBuilder().build(); | |||
| CFEntityGroup.EntityGroup config = | |||
There was a problem hiding this comment.
nit: var name cfEntityGroup or entityGroup
tjennison-work
force-pushed
the
tj-empty
branch
from
b9059d5
to
54ce2d7
Compare
The current behavior of empty entity group criteria is to returna null filter, which effetively ignores the criteria. Instead, empty entity group criteria should check for the existence of any matching occurrence (e.g. any conditionOccurence for a person in a condition criteria).
tjennison-work
force-pushed
the
tj-empty
branch
from
54ce2d7
to
a352d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior of empty entity group criteria is to returna null filter, which effetively ignores the criteria. Instead, empty entity group criteria should check for the existence of any matching occurrence (e.g. any conditionOccurence for a person in a condition criteria).