Simplify dependency locking and version def #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dexamundsen
commented
Oct 3, 2024
•
dexamundsen
commented
- Simplify command for dependency locking by wrapping sub-project tasks within a root task
- Define plugin versions in build.gradle, ensures same version is used across projects
- use Buildscript variables instead of gradle variables. The former is build structure agnostic
- Bump spring boot version from 3.3.3 to 3.3.4; dep management from 1.1.5 to 1.1.6
dexamundsen
commented
Oct 3, 2024
| @@ -3,8 +3,8 @@ plugins { | |||
|
|
|||
| // These plugins are needed to resolve versions of spring dependencies | |||
| // transitively added by terra-common-lib | |||
| id 'org.springframework.boot' version '3.3.3' | |||
| id 'io.spring.dependency-management' version '1.1.5' | |||
| id 'io.spring.dependency-management' version "${vSpringDepMgt}" | |||
There was a problem hiding this comment.
Versions defined as build script variables in build.gradle.
dexamundsen
commented
Oct 3, 2024
| @@ -39,9 +39,9 @@ dependencies { | |||
| implementation 'com.nimbusds:nimbus-jose-jwt:9.37.3' | |||
| } | |||
|
|
|||
| implementation "org.slf4j:slf4j-api:${gradle.vSlf4jApi}" | |||
There was a problem hiding this comment.
Build script variables do not need gradle qualifier, hence removed in all references
dexamundsen
commented
Oct 3, 2024
| repositories { | ||
| mavenCentral() | ||
| } | ||
| } | ||
|
|
||
| gradle.ext { |
dexamundsen
commented
Oct 3, 2024
| @@ -1,22 +1,35 @@ | |||
| // Required by spotless. https://github.com/diffplug/spotless/issues/747 | |||
| buildscript { | |||
| ext { | |||
| // plugin versions | |||
| vSpringBoot = '3.3.4' | |||
There was a problem hiding this comment.
spring boot bumped from 3.3.3 to 3.3.4
dep management plugin bumped from 1.1.5 to 1.1.6
dexamundsen
commented
Oct 3, 2024
| vSwaggerCodegen = '3.0.57' | ||
| vPicocliVersion = '4.7.6' | ||
| vJunit5 = '5.10.2' | ||
| tasks.named('dependencies') { |
There was a problem hiding this comment.
This configures a root task dependencies that depends on below subtasks. hence auto triggered.
tjennison-work
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.