Fix document data feature UI and cohort/concept set loading #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tjennison-work
commented
Jun 27, 2023
tjennison-work
commented
- Editing a document data feature show an empty message instead of an oversized action bar. It would be better disallow editing of data features with no UI but there's no way for the outer app to check that. Future data feature designs chould take into account, or alternatively we could add an editable flag to the API.
- Exiting and returning to a cohort or concept set from the export page could result in an error or endless spinner if no other action was taken that invalidated the SWR cache (e.g. switching apps). Instead of setting state as a side effect of fetching use a useEffect hook so state is always updated at least once, even if nothing is fetched.
* Editing a document data feature show an empty message instead of an oversized action bar. It would be better disallow editing of data features with no UI but there's no way for the outer app to check that. Future data feature designs chould take into account, or alternatively we could add an editable flag to the API. * Exiting and returning to a cohort or concept set from the export page could result in an error or endless spinner if no other action was taken that invalidated the SWR cache (e.g. switching apps). Instead of setting state as a side effect of fetching use a useEffect hook so state is always updated at least once, even if nothing is fetched.
marikomedlock
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.