-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove expanded config files. Move entity-level hint computation into indexing job. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlays that should be in sync.
…hen data types don't match expected.
…er script for aou/test.
tjennison-work
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a lot of files, but the vast majority are trivial changes to config or test files (e.g. delete, rename, new index BQ dataset name). When reviewing, I recommend opening the "File filter" and un-checking ".json" and ".sql", which leaves ~30 code files.
Goals:
expanded
config files.Changes:
hints
API endpoint now queries this BQ table instead of reading from the expanded config file. This takes longer, but I'm not expecting this to be a frequently called endpoint.EXPAND_CONFIG
indexing command with an optionalVALIDATE_CONFIG
indexing command.EXPAND_CONFIG
did.VALIDATE_CONFIG
command looks up the data types and prints them out to make this a little easier.VALIDATE_CONFIG
command successfully.broad
andverily
underlays (vumc
andaou.test
will need to re-index themselves). The only indexing change was a new job, so instead of re-running the entire indexing for all underlays, I copied the most recent index dataset and just re-ran indexing. This only picked up the new jobs. It would have been cleaner to re-run from scratch, but given I'm planning more indexing changes in the near future, was trying to cut down on time I spend re-running.broad
andverily
underlays with a local server + UI.original
config files did not require data types to be specified so we could do this comparison. Now data types are required, so we cannot.