Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IA-5006: filter chartNames based on allowed values #16

Merged
merged 6 commits into from
Jul 3, 2024
Merged

IA-5006: filter chartNames based on allowed values #16

merged 6 commits into from
Jul 3, 2024

Conversation

cpate4
Copy link
Contributor

@cpate4 cpate4 commented Jul 2, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-5006

Summary of changes

What

  • Based on review with AppSec, we were asked to ensure that only a configurable set of allowed chartNames are able to be set.

Why

  • This is to prevent the possibility of deploying non-approved apps

Checklist

  • Thorough tests have been added and/or updated for this change
  • Documentation has been updated for this change
  • This change has been validated in a BEE and/or locally
  • Primary reviewer validated this change

@cpate4 cpate4 requested a review from a team as a code owner July 2, 2024 15:05
sarahgibs
sarahgibs approved these changes Jul 2, 2024
View reviewed changes
Copy link

@sarahgibs sarahgibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for restricting the possible chart names.

cindy-broadinstitute
cindy-broadinstitute approved these changes Jul 2, 2024
View reviewed changes
Copy link

@cindy-broadinstitute cindy-broadinstitute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cpate4 cpate4 merged commit a8b0990 into main Jul 3, 2024
11 checks passed
@cpate4 cpate4 deleted the IA-XXXX_restrict-chartnames-to-config branch July 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahgibs sarahgibs sarahgibs approved these changes

@cindy-broadinstitute cindy-broadinstitute cindy-broadinstitute approved these changes

@lucymcnatt lucymcnatt Awaiting requested review from lucymcnatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpate4 @sarahgibs @cindy-broadinstitute