IA-4907: add POST endpoint for chartVersion #2
Conversation
cpate4
force-pushed
the
IA-4907_implement-create-endpoint
branch
from
25455cf
to
9cbefe9
Compare
service/src/main/java/bio/terra/appmanager/controller/AdminController.java
Outdated
Show resolved
Hide resolved
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/ChartArray' |
There was a problem hiding this comment.
just curious about why this allows multiple chart versions, in my experience I thought the app developers only released one version at a time, so not sure when multiple is necessary?
There was a problem hiding this comment.
I was thinking of the use case where Sherlock (or other) is releasing multiple items at once. Happy to drop this back to being singles (it is an easy enough change either way). Happy to keep this simple at first and we can add on if need be. Thoughts?
There was a problem hiding this comment.
ooh ok that makes sense, ie if we released new versions with the monolith or something, I'm down to keep it as is (and we can always iterate if we want to!)
There was a problem hiding this comment.
... once the build is green I will squash-merge. thank you for talking it through with me -
|
No description provided.