Skip to content

Commit

Permalink
Code review feedback about types.
Browse files Browse the repository at this point in the history
  • Loading branch information
cahrens committed Feb 2, 2024
1 parent 382155d commit 423c1d7
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ jest.mock(
})
);

type useWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): useWorkspacesExports => {
type UseWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): UseWorkspacesExports => {
return {
...jest.requireActual<useWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
...jest.requireActual<UseWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
useWorkspaces: jest.fn(),
};
});
Expand Down
6 changes: 3 additions & 3 deletions src/import-data/ImportData.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ import { selectExistingWorkspacePrompt } from './ImportDataDestination';

type UserEvent = ReturnType<typeof userEvent.setup>;

type useWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): useWorkspacesExports => {
type UseWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): UseWorkspacesExports => {
return {
...jest.requireActual<useWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
...jest.requireActual<UseWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
useWorkspaces: jest.fn(),
};
});
Expand Down
6 changes: 3 additions & 3 deletions src/pages/billing/List/BillingProjectActions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import { WorkspaceWrapper } from 'src/workspaces/utils';
type AjaxContract = ReturnType<typeof Ajax>;
jest.mock('src/libs/ajax');

type useWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): useWorkspacesExports => {
type UseWorkspacesExports = typeof import('src/workspaces/common/state/useWorkspaces');
jest.mock('src/workspaces/common/state/useWorkspaces', (): UseWorkspacesExports => {
return {
...jest.requireActual<useWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
...jest.requireActual<UseWorkspacesExports>('src/workspaces/common/state/useWorkspaces'),
useWorkspaces: jest.fn(),
};
});
Expand Down
6 changes: 3 additions & 3 deletions src/workspace-data/data-table/wds/WdsTroubleshooter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jest.mock('./wds-status', (): WdsStatusExports => {
};
});

type useWorkspaceByIdExports = typeof import('src/workspaces/common/state/useWorkspaceById');
jest.mock('src/workspaces/common/state/useWorkspaceById', (): useWorkspaceByIdExports => {
type UseWorkspaceByIdExports = typeof import('src/workspaces/common/state/useWorkspaceById');
jest.mock('src/workspaces/common/state/useWorkspaceById', (): UseWorkspaceByIdExports => {
return {
...jest.requireActual<useWorkspaceByIdExports>('src/workspaces/common/state/useWorkspaceById'),
...jest.requireActual<UseWorkspaceByIdExports>('src/workspaces/common/state/useWorkspaceById'),
useWorkspaceById: jest.fn(),
};
});
Expand Down
6 changes: 3 additions & 3 deletions src/workspace-data/data-table/wds/WorkspaceLinks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jest.mock('src/libs/nav', (): NavExports => {
};
});

type useWorkspaceByIdExports = typeof import('src/workspaces/common/state/useWorkspaceById');
jest.mock('src/workspaces/common/state/useWorkspaceById', (): useWorkspaceByIdExports => {
type UseWorkspaceByIdExports = typeof import('src/workspaces/common/state/useWorkspaceById');
jest.mock('src/workspaces/common/state/useWorkspaceById', (): UseWorkspaceByIdExports => {
return {
...jest.requireActual<useWorkspaceByIdExports>('src/workspaces/common/state/useWorkspaceById'),
...jest.requireActual<UseWorkspaceByIdExports>('src/workspaces/common/state/useWorkspaceById'),
useWorkspaceById: jest.fn(),
};
});
Expand Down
6 changes: 3 additions & 3 deletions src/workspaces/common/WorkspaceMenu.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ import { tooltipText, WorkspaceMenu } from 'src/workspaces/common/WorkspaceMenu'
import * as WorkspaceUtils from 'src/workspaces/utils';
import { AzureWorkspace, GoogleWorkspace, WorkspaceAccessLevel } from 'src/workspaces/utils';

type useWorkspaceDetailsExports = typeof import('src/workspaces/common/state/useWorkspaceDetails');
jest.mock('src/workspaces/common/state/useWorkspaceDetails', (): useWorkspaceDetailsExports => {
type UseWorkspaceDetailsExports = typeof import('src/workspaces/common/state/useWorkspaceDetails');
jest.mock('src/workspaces/common/state/useWorkspaceDetails', (): UseWorkspaceDetailsExports => {
return {
...jest.requireActual<useWorkspaceDetailsExports>('src/workspaces/common/state/useWorkspaceDetails'),
...jest.requireActual<UseWorkspaceDetailsExports>('src/workspaces/common/state/useWorkspaceDetails'),
useWorkspaceDetails: jest.fn(),
};
});
Expand Down

0 comments on commit 423c1d7

Please sign in to comment.