AJ-954 - Add capability to edit a cell in Data table view in Azure #4588
Conversation
yuliadub
changed the title
There was a problem hiding this comment.
I was comparing current GCP UI with WDS datatypes (https://support.terra.bio/hc/en-us/articles/12553682382363-Data-tables-Additional-resources). I think Reference should be updated to Relation, and then we have a few missing datatypes (date, datetime, float). Is there a max number of items for that pop-up modal? Can you fit them in there or should I ask UX for help with expanding? These other datatypes could be a followup ticket if you like.
In Azure, you actually cant change a type of just a single cell, so that option shouldn't be there ( I removed it). That will be reflected in the "change column type" UI which is a different ticket. (but I am sure this context will be really helpful for it so I added a link to this in there) |
src/libs/ajax/data-table-providers/WdsDataTableProvider.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think this maybe came up earlier as a design decision...so apologies if I'm revisiting, but did you decide that the existing Entity editor logic was divergent enough from what we'll support in WDS that WDS needs its own component?
My instinct would be to attempt to author as little novel component code for this change as possible, and reuse all the existing stuff where provided (providing override seams in the DataTableProvider as needed)...but I get it if it's just too different from what WDS can use.
There was a problem hiding this comment.
yeah, this is something Nick and I were chatting about earlier. My first stab was to try and use them for both.
The main reason why I didnt is because the GCP editor lets the user change the type of any column type, which is just not something we support in Azure at all. (and that applies to each value) PLus Azure has different types that we'd need to support too. it seemed like making the UI work for both given that constraint was just going to be too messy. as I have gotten more familiar with the code, I'll revisit though!
There was a problem hiding this comment.
after revisiting sticking with a different modal still seems like the way to go vs trying to make the two work together side by side.
|
per suggestions during today's demo, changing the edit Modal title. fyi @nawatts @bethsheets |
There was a problem hiding this comment.
It's really nice that this could be shared between entity service and WDS tables.
|
|
Nice work, this was a biggie'! |
Jira Ticket: https://broadworkbench.atlassian.net/browse/AJ-594
This is a draft PR to check if my edits so far look good, I still need to add tests and verify all options but strings when it comes to an edit.
Summary of changes:
Adding editing capabilities to WDS data table view, reusing existing GCP components that are already in the code.
Out of scope for this ticket:
Why
Testing strategy
test.max.workspace.2.-.Data.-.Google.Chrome.2024-01-30.16-24-34.mp4
json edit:
test.max.workspace.2.-.Data.-.Google.Chrome.2024-01-30.16-33-24.mp4
types that are not yet supported:
