Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-1482] Move remainder of Workspaces-owned code out of src/pages/workspaces #4626

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

cahrens
Copy link
Member

@cahrens cahrens commented Feb 1, 2024

Jira Ticket: https://broadworkbench.atlassian.net/browse/WOR-1482

This completes the work started in #4622

  1. WorkspaceDashboard code has been moved to src/workspaces/dashboard, except for the routing page file src/pages/workspaces/WorkspaceDashboard.ts, DashboardPublic, and DashboardAuthContainer.
  2. WorkspaceMigration code has been moved to src/workspaces/migration, except for the routing page file src/pages/workspaces/WorkspaceMigration.ts.
  3. There are no references to src/pages/workspace in src/workspaces.
  4. CODEOWNERS file is updated accordingly.

This is what is left under src/pages/workspaces:

image

@cahrens cahrens marked this pull request as ready for review February 1, 2024 20:27
@cahrens cahrens requested a review from a team as a code owner February 1, 2024 20:27
@@ -20,9 +20,6 @@
/src/pages/LandingPage* @DataBiosphere/terra-cobranding
/src/pages/billing/ @DataBiosphere/broadworkspaces-terra-ui
/src/pages/workspaces/* @DataBiosphere/broadworkspaces-terra-ui
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry at line 22 is non-recursive, so it captures our very minimal Page classes.

@cahrens
Copy link
Member Author

cahrens commented Feb 2, 2024

@blakery FYI that in the last 2 commits I moved some code back to src/pages/workspaces. Talking to @nawatts and @msilva-broad, our desire is to have the page "wrapper" code that includes TopBar and Footer under src/pages. I moved that code back where it was simple to do so, but I am leaving the refactoring to allow such a split in WorkspaceContainer and WorkspacesList for a future change, as it's going to require some substantial work. That would also likely be a good time to do some tsx conversion.

It's also good to keep things that rely on authStore (DashboardAuthContainer) out of src/workspaces….

Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cahrens cahrens added this pull request to the merge queue Feb 2, 2024
Merged via the queue into dev with commit 56307b9 Feb 2, 2024
7 checks passed
@cahrens cahrens deleted the WOR-1482 branch February 2, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants