-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOR-1482] Move remainder of Workspaces-owned code out of src/pages/workspaces #4626
Conversation
@@ -20,9 +20,6 @@ | |||
/src/pages/LandingPage* @DataBiosphere/terra-cobranding | |||
/src/pages/billing/ @DataBiosphere/broadworkspaces-terra-ui | |||
/src/pages/workspaces/* @DataBiosphere/broadworkspaces-terra-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry at line 22 is non-recursive, so it captures our very minimal Page classes.
@blakery FYI that in the last 2 commits I moved some code back to It's also good to keep things that rely on |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 8 New issues |
Jira Ticket: https://broadworkbench.atlassian.net/browse/WOR-1482
This completes the work started in #4622
src/workspaces/dashboard
, except for the routing page filesrc/pages/workspaces/WorkspaceDashboard.ts
,DashboardPublic
, andDashboardAuthContainer
.src/workspaces/migration
, except for the routing page filesrc/pages/workspaces/WorkspaceMigration.ts
.src/pages/workspace
insrc/workspaces
.This is what is left under
src/pages/workspaces
: