Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WM-2484] Make test not flaky #4636

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Conversation

kpierre13
Copy link
Contributor

@kpierre13 kpierre13 commented Feb 6, 2024

Jira Ticket: https://broadworkbench.atlassian.net/browse/[WM-2484]

Summary of changes:

What

  • Changing changeEvent to fireEvent to eliminare WorkflowView test flakiness.

Why

  • WorkflowView test has been flakiness.

Testing strategy

Copy link
Contributor

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great if this stops the test from being flaky. How long does the test take now? Are there other usages of await user.type in the same test that can be converted to make the overall test even faster?

@kpierre13
Copy link
Contributor Author

kpierre13 commented Feb 8, 2024

Great if this stops the test from being flaky. How long does the test take now? Are there other usages of await user.type in the same test that can be converted to make the overall test even faster?

There don't seem to be any more usages of user.type in this file, however the entire suite now takes 8.641 s which is an improvement from 10.781 s that was seen in one of Christina's test runs. It also seems like this change has improved the overall duration of the workflow in the CI by up to 24% in some runs.

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kpierre13 kpierre13 added this pull request to the merge queue Feb 8, 2024
Merged via the queue into dev with commit 0704eff Feb 8, 2024
7 checks passed
@kpierre13 kpierre13 deleted the wm-2484_workflowview_flaky_test_kp branch February 8, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants