[WOR-1461] Emit events for clipboard copy events (WOR-1461). #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
commented
Feb 6, 2024
| @@ -37,6 +40,11 @@ export const AzureStorageDetails = (props: AzureStorageDetailsProps): ReactNode | |||
| 'aria-label': 'Copy resource group ID to clipboard', | |||
| text: azureContext.managedResourceGroupId, | |||
| style: { marginLeft: '0.25rem' }, | |||
| onClick: (_) => { | |||
There was a problem hiding this comment.
Note that onClick doesn't prevent the default action (copying to clipboard) from happening.
cahrens
requested review from
blakery,
a team and
sergiygetlin
and removed request for
a team
|
The IA integration tests are failing in dev/staging as well, and I have notified the IA team. |
blakery
approved these changes
Feb 7, 2024
sergiygetlin
approved these changes
Feb 7, 2024
| @@ -1,11 +1,32 @@ | |||
| import { screen } from '@testing-library/react'; | |||
| import userEvent from '@testing-library/user-event'; | |||
| import * as clipboard from 'clipboard-polyfill/text'; | |||
There was a problem hiding this comment.
is this a normal pattern to use * for import?
There was a problem hiding this comment.
No, not in our "regular" code (though it sometimes still is done for utils files). But it is necessary here for mocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: https://broadworkbench.atlassian.net/browse/WOR-1461
Adds events for clipboard copy events on the dashboard, as we wish to see how often people click them.
Azure:
GCP:
