Id 367 get user registration from sam #4716
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| import { DeepPartial } from '@terra-ui-packages/core-utils'; | ||
| import { asMockedFn } from '@terra-ui-packages/test-utils'; | ||
| import { act } from '@testing-library/react'; | ||
| import { loadTerraUser } from 'src/auth/auth'; | ||
| import { Ajax } from 'src/libs/ajax'; | ||
| import { GroupRole } from 'src/libs/ajax/Groups'; | ||
| import { SamUserTermsOfServiceDetails } from 'src/libs/ajax/TermsOfService'; | ||
| import { SamUserResponse } from 'src/libs/ajax/User'; | ||
| import { TerraUserState, userStore } from 'src/libs/state'; | ||
|
|
||
| jest.mock('src/libs/ajax'); | ||
|
|
||
| type AjaxExports = typeof import('src/libs/ajax'); | ||
| type AjaxContract = ReturnType<AjaxExports['Ajax']>; | ||
|
|
||
| jest.mock('react-notifications-component', () => { | ||
| return { | ||
| Store: { | ||
| addNotification: jest.fn(), | ||
| removeNotification: jest.fn(), | ||
| }, | ||
| }; | ||
| }); | ||
|
|
||
| const samUserDate = new Date('1970-01-01'); | ||
|
|
||
| const mockSamUserResponse: SamUserResponse = { | ||
| id: 'testId', | ||
| googleSubjectId: 'testGoogleSubjectId', | ||
| email: 'testEmail', | ||
| azureB2CId: 'testAzureB2CId', | ||
| allowed: true, | ||
| createdAt: samUserDate, | ||
| registeredAt: samUserDate, | ||
| updatedAt: samUserDate, | ||
| }; | ||
|
|
||
| const mockSamUserTermsOfServiceDetails: SamUserTermsOfServiceDetails = { | ||
| latestAcceptedVersion: '1234', | ||
| acceptedOn: samUserDate, | ||
| permitsSystemUsage: true, | ||
| isCurrentVersion: true, | ||
| }; | ||
|
|
||
| const mockTerraUserProfile = { | ||
| firstName: 'testFirstName', | ||
| lastName: 'testLastName', | ||
| institute: 'testInstitute', | ||
| contactEmail: 'testContactEmail', | ||
| title: 'testTitle', | ||
| department: 'testDepartment', | ||
| interestInTerra: 'testInterestInTerra', | ||
| programLocationCity: 'testProgramLocationCity', | ||
| programLocationState: 'testProgramLocationState', | ||
| programLocationCountry: 'testProgramLocationCountry', | ||
| researchArea: 'testResearchArea', | ||
| starredWorkspaces: 'testStarredWorkspaces', | ||
| }; | ||
|
|
||
|
|
||
| const testSamUserAllowancesDetails = { | ||
| enabled: true, | ||
| termsOfService: true, | ||
| }; | ||
|
|
||
| const testSamUserAllowances = { | ||
| allowed: true, | ||
| details: testSamUserAllowancesDetails, | ||
| }; | ||
|
|
||
| const mockNihDatasetPermission = { | ||
| name: 'testNihDatasetPermissionName', | ||
| authorized: true, | ||
| }; | ||
|
|
||
| const mockOrchestrationNihStatusResponse = { | ||
| linkedNihUsername: 'testLinkedNihUsername', | ||
| datasetPermissions: mockNihDatasetPermission, | ||
| linkExpireTime: 1234, | ||
| }; | ||
|
|
||
| const mockCurrentUserGroupMembership = { | ||
| groupEmail: 'testGroupEmail', | ||
| groupName: 'testGroupName', | ||
| role: 'member' as GroupRole, | ||
| }; | ||
|
|
||
| // TODO centralize Ajax mock setup so it can be reused across tests | ||
| describe('a request to load a terra user', () => { | ||
| // reset userStore state before each test | ||
| beforeEach(() => { | ||
| userStore.reset; | ||
| }); | ||
| describe('when successful', () => { | ||
| // Arrange (shared between tests for the success case) | ||
| const getUserAllowancesFunction = jest.fn().mockResolvedValue(testSamUserAllowances); | ||
| const getUserAttributesFunction = jest.fn().mockResolvedValue({ marketingConsent: false }); | ||
| const getUserTermsOfServiceDetailsFunction = jest.fn().mockResolvedValue(mockSamUserTermsOfServiceDetails); | ||
| const getEnterpriseFeaturesFunction = jest.fn().mockResolvedValue([]); | ||
| const getSamUserResponseFunction = jest.fn().mockResolvedValue(mockSamUserResponse); | ||
| const getNihStatusFunction = jest.fn().mockResolvedValue(mockOrchestrationNihStatusResponse); | ||
| const getFenceStatusFunction = jest.fn().mockResolvedValue({}); | ||
|
|
||
| asMockedFn(Ajax).mockImplementation( | ||
| () => | ||
| ({ | ||
| User: { | ||
| getUserAllowances: getUserAllowancesFunction, | ||
| getUserAttributes: getUserAttributesFunction, | ||
| getUserTermsOfServiceDetails: getUserTermsOfServiceDetailsFunction, | ||
| getEnterpriseFeatures: getEnterpriseFeaturesFunction, | ||
| getSamUserResponse: getSamUserResponseFunction, | ||
| getNihStatus: getNihStatusFunction, | ||
| getFenceStatus: getFenceStatusFunction, | ||
| profile: { | ||
| get: jest.fn().mockReturnValue(mockTerraUserProfile), | ||
| }, | ||
| }, | ||
| TermsOfService: { | ||
| getUserTermsOfServiceDetails: jest.fn().mockReturnValue({}), | ||
| }, | ||
| Groups: { | ||
| list: jest.fn().mockReturnValue([mockCurrentUserGroupMembership]), | ||
| }, | ||
| } as DeepPartial<AjaxContract> as AjaxContract) | ||
| ); | ||
Shakespeared marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| it('should include a samUserResponse', async () => { | ||
| // Act | ||
| await act(() => loadTerraUser()); | ||
|
|
||
| // Assert | ||
| expect(getSamUserResponseFunction).toHaveBeenCalled(); | ||
| }); | ||
| it('should update the samUser in state', async () => { | ||
| // Act | ||
| await act(() => loadTerraUser()); | ||
|
|
||
| let samUser; | ||
| await act(async () => { | ||
| samUser = await getSamUserResponseFunction.mock.results[0].value; | ||
| }); | ||
| userStore.update((state: TerraUserState) => ({ | ||
| ...state, | ||
| samUser, | ||
| })); | ||
| // Assert | ||
| expect(getSamUserResponseFunction).toHaveBeenCalled(); | ||
| expect(userStore.get().samUser).toEqual(mockSamUserResponse); | ||
| }); | ||
| describe('when not successful', () => { | ||
| it('should fail with an error', async () => { | ||
| // // Arrange | ||
| // mock a failure to get samUserResponse | ||
| const getSamUserResponseFunction = jest.fn().mockRejectedValue(new Error('unknown')); | ||
|
|
||
| asMockedFn(Ajax).mockImplementation( | ||
| () => | ||
| ({ | ||
| User: { | ||
| getUserAllowances: getUserAllowancesFunction, | ||
| getUserAttributes: getUserAttributesFunction, | ||
| getUserTermsOfServiceDetails: getUserTermsOfServiceDetailsFunction, | ||
| getEnterpriseFeatures: getEnterpriseFeaturesFunction, | ||
| getSamUserResponse: getSamUserResponseFunction, | ||
| profile: { | ||
| get: jest.fn().mockReturnValue(mockTerraUserProfile), | ||
| }, | ||
| }, | ||
| TermsOfService: { | ||
| getUserTermsOfServiceDetails: jest.fn().mockReturnValue({}), | ||
| }, | ||
| } as DeepPartial<AjaxContract> as AjaxContract) | ||
| ); | ||
| // Act, Assert | ||
| // this expect.assertions is here to prevent the test from passing if the error is not thrown | ||
| expect.assertions(1); | ||
Shakespeared marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| try { | ||
| await act(() => loadTerraUser()); | ||
| } catch (error) { | ||
| expect(error).toEqual(new Error('unknown')); | ||
| } | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also just rely on the
createdAtdate, since its not nullable in Sam's DB. That might be preferable, just in case there's a realcreatedAt, but not aregisteredAt, for some reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to user
createdAtbecause then a user who is invited, waits a month to register, then comes to Terra would immediately be shown the survey