[UIE-153] Create analysis package #4718
Conversation
| "lib/types/**/*.d.ts" | ||
| ], | ||
| "dependencies": { | ||
| "@terra-ui-packages/components": "^0.0.6", |
There was a problem hiding this comment.
This points out an issue we'll have to deal with sometime where packages in the Terra UI repository can depend on older versions of Terra UI packages than the current version in the repository. I can take care of it though.
| { | ||
| "extends": "../../tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "noImplicitAny": true, |
There was a problem hiding this comment.
This is stricter than the Terra UI app's configuration, so some code may have to be updated when it's moved over, but I think it's well worth it.
https://www.typescriptlang.org/tsconfig#noImplicitAny
| @@ -0,0 +1,49 @@ | |||
| { | |||
| "name": "@terra-ui-packages/analysis", | |||
There was a problem hiding this comment.
Opinions on name? This matches the existing "analysis" folder, but could also be "interactive-analysis", etc (because interactive analysis more precisely describes the feature area, not because of the team name).
There was a problem hiding this comment.
I think analysis is fine. It's closest to the name of the tab where all the functionality lives
There was a problem hiding this comment.
Not super familiar with packaging, so it might be good to have another set of eyes. Looks good though, I imagine it will probably be better to iterate on these configs as we add files to the package instead of getting too hung up on the initial setup semantics
A starting point for separating out interactive analysis components to be shared with AoU.