-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIE-153] Create analysis package #4718
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// ESLint thinks @terra-ui-packages/test-utils should be listed in dependencies instead of devDependencies. | ||
// TODO: Fix this in ESLint configuration. | ||
// eslint-disable-next-line import/no-extraneous-dependencies | ||
import { getJestConfig } from '@terra-ui-packages/test-utils'; | ||
|
||
export default getJestConfig(); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{ | ||
"name": "@terra-ui-packages/analysis", | ||
"version": "0.0.1", | ||
"scripts": { | ||
"build": "vite build --emptyOutDir", | ||
"dev": "vite build --mode=development --watch", | ||
"test": "jest" | ||
}, | ||
"type": "module", | ||
"module": "./lib/es/index.js", | ||
"main": "./lib/cjs/index.cjs", | ||
"types": "./lib/types/index.d.ts", | ||
"exports": { | ||
".": { | ||
"import": "./lib/es/index.js", | ||
"require": "./lib/cjs/index.cjs", | ||
"types": "./lib/types/index.d.ts" | ||
} | ||
}, | ||
"files": [ | ||
"lib/cjs/**", | ||
"lib/es/**", | ||
"lib/types/**/*.d.ts" | ||
], | ||
"dependencies": { | ||
"@terra-ui-packages/components": "^0.0.6", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This points out an issue we'll have to deal with sometime where packages in the Terra UI repository can depend on older versions of Terra UI packages than the current version in the repository. I can take care of it though. |
||
"lodash": "^4.17.21" | ||
}, | ||
"devDependencies": { | ||
"@terra-ui-packages/build-utils": "^1.0.0", | ||
"@terra-ui-packages/test-utils": "*", | ||
"@testing-library/dom": "^9.3.1", | ||
"@testing-library/react": "^14.0.0", | ||
"@testing-library/user-event": "^14.4.3", | ||
"@types/jest": "^28.1.8", | ||
"@types/lodash": "^4.14.184", | ||
"@types/react": "^18.2.15", | ||
"@types/testing-library__jest-dom": "^5.14.9", | ||
"jest": "^27.4.3", | ||
"react": "18.2.0", | ||
"react-dom": "18.2.0", | ||
"typescript": "~5.1.6", | ||
"vite": "^4.5.2" | ||
}, | ||
"peerDependencies": { | ||
"react": "18.2.0", | ||
"react-dom": "18.2.0" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"extends": "../../tsconfig.base.json", | ||
"compilerOptions": { | ||
"noImplicitAny": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is stricter than the Terra UI app's configuration, so some code may have to be updated when it's moved over, but I think it's well worth it. |
||
"outDir": "lib/types", | ||
"rootDir": "src" | ||
}, | ||
"include": ["src"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { viteConfig as defineBaseConfig } from '@terra-ui-packages/build-utils'; | ||
|
||
export default defineBaseConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opinions on name? This matches the existing "analysis" folder, but could also be "interactive-analysis", etc (because interactive analysis more precisely describes the feature area, not because of the team name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
analysis
is fine. It's closest to the name of the tab where all the functionality lives