[WM-2556] Show Literal Input Values #4729
Conversation
| @@ -96,6 +96,10 @@ const SubmissionDetailsInputsTable = ({ configuredInputDefinition }: SubmissionD | |||
| .source as RecordLookupInputSource; | |||
| return h(TextCell, [source.record_attribute]); | |||
| } | |||
| if (inputTableData[rowIndex].source.type === 'literal') { | |||
There was a problem hiding this comment.
I don't remember the exact schema definition, but will this also work for Optional literal inputs? If not I wonder if we should also add support for that too?
There was a problem hiding this comment.
Hm, that's a good question. I'll try to find a workflow with an optional to try and see how this works.
There was a problem hiding this comment.
I think the fact that it's the source instead of the type means it'll either be a "none" or a "literal", there's no such thing as a "optional literal" source type... but I might be wrong and 100% worth testing!
There was a problem hiding this comment.
Optional literal inputs work with this change as well
| @@ -96,6 +96,10 @@ const SubmissionDetailsInputsTable = ({ configuredInputDefinition }: SubmissionD | |||
| .source as RecordLookupInputSource; | |||
| return h(TextCell, [source.record_attribute]); | |||
| } | |||
| if (inputTableData[rowIndex].source.type === 'literal') { | |||
There was a problem hiding this comment.
I am not sure what is the state of tests for this component, but it would be good to add some tests for this.
| @@ -96,6 +96,10 @@ const SubmissionDetailsInputsTable = ({ configuredInputDefinition }: SubmissionD | |||
| .source as RecordLookupInputSource; | |||
| return h(TextCell, [source.record_attribute]); | |||
| } | |||
| if (inputTableData[rowIndex].source.type === 'literal') { | |||
There was a problem hiding this comment.
I think the fact that it's the source instead of the type means it'll either be a "none" or a "literal", there's no such thing as a "optional literal" source type... but I might be wrong and 100% worth testing!
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jira Ticket: https://broadworkbench.atlassian.net/browse/[WM-2556]
Summary of changes:
What
Why
Testing strategy