DC-857: hierarchy view stub removal #4730
Conversation
…i-change # Conflicts: # src/dataset-builder/ConceptSetCreator.ts
…into ps/dc-857-hierarchy-api-change
That's a good point, it is part of the UX spec but there wasn't a ticket for it yet, I created https://broadworkbench.atlassian.net/browse/DC-950 for it. |
There was a problem hiding this comment.
Looks good! I think a comment will be useful in TreeGrid.ts explaining that a child can have several parents? Also, when you're selecting parents[0] to create a root (i.e ConceptSelector line 86), explaining why the first is chosen in the code may be helpful.
…into ps/dc-857-hierarchy-api-change
… UI instead of the API layer
|
Jira Ticket: https://broadworkbench.atlassian.net/browse/DC-857
What
Update UI code with backend API changes for "get hierarchy" snapshot builder API.
Why
When adding backend support for "get concept hierarchy", we found that the concept tree is actually a graph. So the original API plan to pass a single tree root in the reply no longer works. To support a tree with shared branches, the response is now a list of parents and their children. As in an earlier API, the first element in the list is the root node. (Although the root node could also be derived by finding the one node that's not a child of any other node.)
Testing strategy
Unit tests, manually tested using local TDR.
Visual Aids
In this clip the Observation "Kitchen Practice" is shown in the hierarchy view. This concept occurs in two different subtrees in the hierarchy view. The actual time to bring up the hierarchy view is about 20 seconds.
demo.mov