[UIE-198] NameModal storybook #4925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlilynolting you have build errors |
cahrens
reviewed
Jul 8, 2024
| onDismiss: () => {}, | ||
| thing: 'Dog', | ||
| value: 'Lassie', | ||
| validator: (value) => (value === 'Fido' ? false : 'I only like dogs named Fido'), |
There was a problem hiding this comment.
I would suggest a case-insensitive match. I had trouble figuring out how to get rid of the error message, as I tried "fido" or "FIDO".
There was a problem hiding this comment.
Thanks; I'll make it /i
cahrens
reviewed
Jul 8, 2024
| render: (args) => { | ||
| const StoryWrapper = (): React.ReactNode => { | ||
| const [isModalOpen, modalOpen] = useState(false); | ||
| const [value, setValue] = useState({ name: 'Laddie' }); |
There was a problem hiding this comment.
You used "Lassie" as the value for the modal.
There was a problem hiding this comment.
Yeah this was intended to be a different value but it doesn't really matter
cahrens
reviewed
Jul 8, 2024
| }; | ||
| return ( | ||
| <div> | ||
| <div>{`My dog's name is ${value.name}.`}</div> |
There was a problem hiding this comment.
Could you put a little spacing between the div and the button?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/UIE-198
A little Storybook for the NameModal component.