Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IA-5074] Improve IA integration test stability #5122

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

cahrens
Copy link
Member

@cahrens cahrens commented Oct 3, 2024

Jira Ticket: https://broadworkbench.atlassian.net/browse/IA-5074

We are seeing sporadic failures in these tests that indicate that clicking on the name of the newly created notebook failed (the item to click on did exist as no error was thrown, but apparently it was obscured and the click callback did not get triggered). The notebook/analyses is clicked on immediately after the compute modal slides shut, and given that it has an animated transition, I am guessing that is the cause of the problem.

Example failure:

Test: run-rstudio
Status: failed
Failure messages: TimeoutError: Waiting for selector `//*[contains(normalize-space(.),"PREVIEW (READ-ONLY)")]` failed: Waiting failed: 30000ms exceeded
    at new WaitTask (/mnt/ramdisk/.yarn/cache/puppeteer-core-npm-22.7.1-6da5f6bf12-893a366c16.zip/node_modules/puppeteer-core/src/common/WaitTask.ts:82:28)
    at IsolatedWorld.waitForFunction (/mnt/ramdisk/.yarn/cache/puppeteer-core-npm-22.7.1-6da5f6bf12-893a366c16.zip/node_modules/puppeteer-core/src/api/Realm.ts:74:22)
    at Function.waitFor (/mnt/ramdisk/.yarn/cache/puppeteer-core-npm-22.7.1-6da5f6bf12-893a366c16.zip/node_modules/puppeteer-core/src/common/QueryHandler.ts:159:50)
    at CdpFrame.waitForSelector (/mnt/ramdisk/.yarn/cache/puppeteer-core-npm-22.7.1-6da5f6bf12-893a366c16.zip/node_modules/puppeteer-core/src/api/Frame.ts:660:13)
    at CdpPage.waitForSelector (/mnt/ramdisk/.yarn/cache/puppeteer-core-npm-22.7.1-6da5f6bf12-893a366c16.zip/node_modules/puppeteer-core/src/api/Page.ts:2819:12)
Failure details: [
  {
    "name": "TimeoutError"
  }
]

Using a delay of 5 seconds passed 4/4 runs. This PR attempts to use a delay that matches the transition animation time, but that may turn out to be flaky given the other operations that are also occurring (spinners in both the side modal and over the page itself).

@cahrens cahrens changed the title See if waiting for spinners to go away helps stability [IA-5074] Improve IA integration test stability Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

@cahrens cahrens marked this pull request as ready for review October 3, 2024 20:35
@cahrens cahrens requested a review from a team as a code owner October 3, 2024 20:35
@cahrens cahrens added this pull request to the merge queue Oct 4, 2024
Merged via the queue into dev with commit 3e1f96a Oct 4, 2024
10 checks passed
@cahrens cahrens deleted the ia-test-stability branch October 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants