Wire up HTTP LZS client (step 2) #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin to migrate over to the de-amalgamated LZS HTTP service
…gin to migrate over to the de-amalgamated LZS HTTP service
aherbst-broad
force-pushed
the
arh-wireup-lzs-mk2
branch
from
0f78e9a
to
a8062a0
Compare
aherbst-broad
force-pushed
the
arh-wireup-lzs-mk2
branch
from
a8062a0
to
cb2df49
Compare
aherbst-broad
requested review from
blakery,
marctalbott and
sergiygetlin
and removed request for
a team
aherbst-broad
commented
Apr 19, 2024
service/src/main/java/bio/terra/workspace/amalgam/landingzone/azure/HttpLandingZoneService.java
Outdated
Show resolved
Hide resolved
sergiygetlin
approved these changes
Apr 22, 2024
blakery
approved these changes
Apr 22, 2024
aherbst-broad
commented
Apr 24, 2024
...e/src/main/java/bio/terra/workspace/service/resource/controlled/cloud/azure/vm/LzsRetry.java
Outdated
Show resolved
Hide resolved
marctalbott
approved these changes
Apr 24, 2024
|
aherbst-broad
added a commit
that referenced
this pull request
May 1, 2024
This reverts commit f02e8be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is the followup to #1709.
We want to be able to switch over to using the new Landing Zone web service when we are ready. The previous PR (linked above) introduced a new interface that abstracted over the direct library calls ("amalgamated"). The next step is to introduce an implementation of that interface for the LZS HTTP API and the needed configuration that will allows switching to that API when ready.
This PR
HttpLandingZoneServiceimplementation of theWorkspaceLandingZoneServiceinterface. This is a "vanilla" WSM HTTP client layer, with the requisiteLzsRetryclass and internal exception hierarchy.LandingZoneApiTypeAdapterto help map between Landing Zone Service API client types and the needed WSM API types forLandingZoneApiDispatchLandingZoneApiTypeAdapterHttpLandingZoneServiceclass. My plan is to introduce coverage for that code via pact tests as described in WOR-1119.