[WOR-1772] Catch duplicate PAO exception when trying to create a PAO that has been deleted #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctalbott
requested review from
cahrens and
aherbst-broad
and removed request for
a team
marctalbott
commented
Jul 11, 2024
| @@ -113,7 +113,16 @@ public TpsPaoGetResult getOrCreatePao( | |||
| return pao.get(); | |||
| } | |||
| // Workspace doesn't have a PAO, so create an empty one for it. | |||
| createPao(objectId, null, component, objectType); | |||
| try { | |||
There was a problem hiding this comment.
I tried to get a test around this where we have some other policy tests and wasn't able to get the mocking to cooperate. I can try some other things, but felt like this was a bit of a rare situation and wasn't worth the extra effort. Let me know if you disagree and I'll see what else we can do to get coverage here.
cahrens
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Thanks, @marctalbott ! A test would be nice, but I agree that it may not necessarily be worth the effort.
|
aherbst-broad
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOR-1772