Support for deployment in Azure Government Cloud (WSM) #1806
Conversation
bennettn4
requested review from
dvoet and
samanehsan
and removed request for
a team
settings.gradle
Outdated
| @@ -11,6 +11,7 @@ pluginManagement { | |||
| } | |||
| } | |||
| } | |||
| mavenLocal() | |||
There was a problem hiding this comment.
I don't think we want this in general
There was a problem hiding this comment.
Removed, good catch this was for local testing
| AzureUSGovernmentCloud: ${DB_SERVER_NAME}.postgres.database.usgovcloudapi.net | ||
| AzureCloud: ${DB_SERVER_NAME}.postgres.database.azure.com |
There was a problem hiding this comment.
these are db host names, can you include that in the property name?
There was a problem hiding this comment.
Made subvalues of dbHostNames
| port: 5432 | ||
| host: ${azureEnvironmentConfig.${AZURE_ENVIRONMENT:AzureCloud}}:5432 | ||
| #host: ${DB_SERVER_NAME}.postgres.database.azure.com:5432 |
There was a problem hiding this comment.
remove the commented line and the one below
| @@ -166,6 +166,7 @@ workspace: | |||
| state: operating | |||
|
|
|||
| azure: | |||
| azureEnvironment: AZURE | |||
There was a problem hiding this comment.
Is this necessary? There is already azure-environment on line 178 with the value ${env.azure.environment} which refers to line 33 environment: ${AZURE_ENVIRONMENT:AZURE}
|
|
Part of large effort to add support for services to run in Azure Government cloud.
https://broadworkbench.atlassian.net/browse/TOAZ-372
See related pull requests here:
workbench-libs sam bpm wsm cromwell terra-helmfile