-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for deployment in Azure Government Cloud (WSM) #1806
base: main
Are you sure you want to change the base?
Changes from 18 commits
509cca4
c5debeb
67429ab
3558db8
69276ba
b4abf04
cb3d31e
f4d05a4
0c9e9e9
f0ea9f5
6d1ff41
5a16ece
5feb939
f7f3676
286df3f
76e0137
ec8fad7
1a31bd6
e6227e1
ef9f286
992a70c
c653e85
642ba0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,14 @@ | ||
azureEnvironmentConfig: | ||
AzureUSGovernmentCloud: ${DB_SERVER_NAME}.postgres.database.usgovcloudapi.net | ||
AzureCloud: ${DB_SERVER_NAME}.postgres.database.azure.com | ||
|
||
env: | ||
db: | ||
host: ${DB_SERVER_NAME}.postgres.database.azure.com:5432 | ||
url: ${DB_SERVER_NAME}.postgres.database.azure.com | ||
port: 5432 | ||
host: ${azureEnvironmentConfig.${AZURE_ENVIRONMENT:AzureCloud}}:5432 | ||
#host: ${DB_SERVER_NAME}.postgres.database.azure.com:5432 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove the commented line and the one below There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
url: ${azureEnvironmentConfig.${AZURE_ENVIRONMENT:AzureCloud}} | ||
#url: ${DB_SERVER_NAME}.postgres.database.azure.com | ||
user: ${ADMIN_DB_USER_NAME} | ||
connectToDatabase: ${CONNECT_TO_DATABASE:postgres} | ||
params: | ||
|
@@ -16,6 +22,7 @@ env: | |
blobContainerName: ${BLOB_CONTAINER_NAME} | ||
blobContainerUrlAuthenticated: ${BLOB_CONTAINER_URL_AUTHENTICATED} | ||
encryptionKey: ${ENCRYPTION_KEY} | ||
azureEnvironment: ${AZURE_ENVIRONMENT} | ||
|
||
|
||
spring: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,6 +166,7 @@ workspace: | |
state: operating | ||
|
||
azure: | ||
azureEnvironment: AZURE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this necessary? There is already azure-environment on line 178 with the value There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
sas-token-start-time-minutes-offset: 15 | ||
sas-token-expiry-time-minutes-offset: 60 | ||
sas-token-expiry-time-maximum-minutes-offset: 1440 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ pluginManagement { | |
} | ||
} | ||
} | ||
mavenLocal() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we want this in general There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed, good catch this was for local testing |
||
maven { | ||
url "https://broadinstitute.jfrog.io/broadinstitute/libs-snapshot-local/" | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are db host names, can you include that in the property name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made subvalues of dbHostNames