[DX] Improve contribution experience #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannmoinet
force-pushed
the
yoann/internal-injection-plugin
branch
from
113e3e5
to
a5e8bb0
Compare
yoannmoinet
force-pushed
the
yoann/add-some-doc
branch
from
fd94f00
to
cd77987
Compare
yoannmoinet
force-pushed
the
yoann/add-some-doc
branch
from
02cde7a
to
cd77987
Compare
elbywan
approved these changes
Oct 2, 2024
README.md
Outdated
| rawConfig?: any; | ||
| variant?: string; // Major version of the bundler (webpack 4, webpack 5) | ||
| variant: string; // Major version of the bundler (webpack 4, webpack 5) |
There was a problem hiding this comment.
might be nice to tell the user that this will be an empty string for other bundlers (IIUC)
const variant =
meta.framework === 'webpack' ? (meta.webpack.compiler['webpack'] ? '5' : '4') : '';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We were missing some documentation.
Some of our tooling was outdated and slipped through the cracks.
How?