Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vite] Remove leaking dependencies #94

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

yoannmoinet
Copy link
Member

What and why?

Some of our code is using webpack as a lib.
It was necessary a long time ago, but it's not anymore, if we refine a bit how we do things.

Also, vite can call the plugin's factory with no options apparently (discovered during reproduction).

Finally, also during reproduction, I got some errors related to the usage of module in our bundled lib.

How?

  • Change how we bootstrap our bundles (with some module detection).
  • Clean dependencies and peerDependencies (make them optional for the telemetry module).
  • Remove the need for webpack as a lib in the telemetry module.

Fixes #91

@yoannmoinet yoannmoinet requested a review from a team as a code owner September 5, 2024 08:11
@yoannmoinet yoannmoinet requested review from egeriis and removed request for a team September 5, 2024 08:11
@elbywan elbywan self-requested a review September 5, 2024 08:12
@yoannmoinet yoannmoinet merged commit 7420768 into master Sep 5, 2024
5 checks passed
@yoannmoinet yoannmoinet deleted the yoann/remove-webpack-from-vite branch September 5, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove webpack dependency from Vite plugin or make it explicit
2 participants