Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-inflector dependency #922

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add dry-inflector dependency #922

merged 2 commits into from
Jul 10, 2024

Conversation

AliDatadog
Copy link
Contributor

What does this PR do?

This PR adds the dry-inflector dependency to mitigate this error:

❯ bundle exec rake release
rake aborted!
NotImplementedError: Virtus needs dry-inflector gem to constantize namespaced constant names
/Users/user/dd/chef-datadog/tasks/config_specification/models.rb:73:in `<top (required)>'
/Users/user/dd/chef-datadog/tasks/config_specification.rb:23:in `require_relative'
/Users/user/dd/chef-datadog/tasks/config_specification.rb:23:in `<top (required)>'
/Users/user/dd/chef-datadog/tasks/create_integration_monitor.rake:19:in `require_relative'
/Users/user/dd/chef-datadog/tasks/create_integration_monitor.rake:19:in `<top (required)>'
/Users/user/.rbenv/versions/2.7.7/bin/bundle:23:in `load'
/Users/user/.rbenv/versions/2.7.7/bin/bundle:23:in `<main>'

Caused by:
LoadError: cannot load such file -- dry/inflector
/Users/user/dd/chef-datadog/tasks/config_specification/models.rb:73:in `<top (required)>'
/Users/user/dd/chef-datadog/tasks/config_specification.rb:23:in `require_relative'
/Users/user/dd/chef-datadog/tasks/config_specification.rb:23:in `<top (required)>'
/Users/user/dd/chef-datadog/tasks/create_integration_monitor.rake:19:in `require_relative'
/Users/user/dd/chef-datadog/tasks/create_integration_monitor.rake:19:in `<top (required)>'
/Users/user/.rbenv/versions/2.7.7/bin/bundle:23:in `load'
/Users/user/.rbenv/versions/2.7.7/bin/bundle:23:in `<main>'

Fixed by adding dry-inflector in the Gemfile

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

@AliDatadog AliDatadog requested a review from a team as a code owner July 10, 2024 08:59
Gemfile Outdated Show resolved Hide resolved
@AliDatadog AliDatadog merged commit 20e1a2f into main Jul 10, 2024
2 checks passed
@AliDatadog AliDatadog deleted the ali/pin-dry-inflector-dep branch July 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants