Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unmarshal and UnmarshalExact method from the config API #29992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hush-hush
Copy link
Member

What does this PR do?

Remove Unmarshal and UnmarshalExact method from the config API.

This helps reduce the API of the config which will simplify the replacement of viper.

Describe how to test/QA your changes

Running the CI is enough.

@hush-hush hush-hush requested review from a team as code owners October 9, 2024 16:04
@hush-hush hush-hush added changelog/no-changelog team/agent-shared-components qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Oct 9, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 9, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46375107 --os-family=ubuntu

Note: This applies to commit 4ba1877

Copy link

cit-pr-commenter bot commented Oct 9, 2024

Regression Detector

Regression Detector Results

Run ID: bd6a2fe5-7396-4cb9-82ab-d085d84de084 Metrics dashboard Target profiles

Baseline: f4e705e
Comparison: 4ba1877

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.55 [+0.82, +2.28] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.72 [-1.78, +3.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.13, +0.36] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.04 [-0.14, +0.22] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.35, +0.33] 1 Logs
otel_to_otel_logs ingress throughput -0.02 [-0.83, +0.78] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.25, +0.19] 1 Logs
idle memory utilization -0.21 [-0.26, -0.15] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.47 [-0.96, +0.01] 1 Logs
basic_py_check % cpu utilization -0.88 [-3.62, +1.87] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.96 [-1.01, -0.91] 1 Logs
idle_all_features memory utilization -1.28 [-1.40, -1.17] 1 Logs bounds checks dashboard
file_tree memory utilization -2.88 [-3.02, -2.74] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_1000ms_latency memory_usage 0/10
file_to_blackhole_300ms_latency memory_usage 0/10
file_to_blackhole_500ms_latency memory_usage 0/10
idle memory_usage 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pkg/metrics/histogram.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the pkg/config/structure dependency is fixed up

@hush-hush hush-hush force-pushed the maxime/remove-unused-unmarshall-methods branch from 93a8b08 to c934bc9 Compare October 10, 2024 16:22
@hush-hush hush-hush requested review from a team as code owners October 10, 2024 16:22
@hush-hush hush-hush force-pushed the maxime/remove-unused-unmarshall-methods branch from c934bc9 to 4ba1877 Compare October 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants