[CONTP-402] Store config values in config webhook struct

[gabedos]

What does this PR do?

Follow up to last PR, by storing relevant config values in struct.

Motivation

Currently, the config mutator is storing a pointer to the datadogConfig and fetching values as needed. Unfortunately, caching does not work with the config component so we are storing the relevant values in the webhook struct instead.

Describe how to test/QA your changes

Unit tests should be fine.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Run ID: e7fe13ef-0292-40e9-975e-991446c1819e Metrics dashboard Target profiles

Baseline: 84713c6
Comparison: ac1205c

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.60	[+0.87, +2.34]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.39	[+0.33, +0.45]	1	Logs
➖	idle	memory utilization	+0.33	[+0.28, +0.37]	1	Logs
➖	idle_all_features	memory utilization	+0.21	[+0.12, +0.31]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.13	[-0.11, +0.38]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.11	[-0.06, +0.29]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.09, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.23, +0.21]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.36, +0.31]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.52, +0.45]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.57	[-1.37, +0.23]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-0.57	[-2.98, +1.84]	1	Logs
➖	file_tree	memory utilization	-0.84	[-0.95, -0.72]	1	Logs
➖	basic_py_check	% cpu utilization	-1.63	[-4.24, +0.98]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[clamoriniere]

maybe for readability, you can split the list of fields with an empty line before, or create a sub structure type config struct

all the field that come from the config component in the type conf struct

[gabedos]

Thank you for the comment. I totally agree this struct was getting a little out of hand.

[davidor]

@gabedos the ci/circleci:unit_tests job is failing but it's unrelated to your changes. It should pass if you rebase on top of main.

[clamoriniere]

regrouping the fields coming from the datadogConfig in a sub structure can help for the readability

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 46328375 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46328375 --os-family=ubuntu

Note: This applies to commit ac1205c

[clamoriniere]

Nice work 👏