switch to composite store and use composite entity id in tagger component #30019

adel121 · 2024-10-10T13:21:21Z

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter · 2024-10-10T13:30:42Z

Go Package Import Differences

Baseline: 967da85
Comparison: cbd8037

binary	os	arch	change
agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
iot-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
iot-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
heroku-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
cluster-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
cluster-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
cluster-agent-cloudfoundry	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
cluster-agent-cloudfoundry	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
dogstatsd	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
dogstatsd	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
process-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
process-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
process-agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
process-agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
process-agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
heroku-process-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
security-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
security-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
serverless	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
serverless	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
system-probe	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
system-probe	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
system-probe	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
trace-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
trace-agent	linux	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
trace-agent	windows	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
trace-agent	darwin	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
trace-agent	darwin	arm64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger
heroku-trace-agent	linux	amd64	+0, -1 -github.com/DataDog/datadog-agent/pkg/util/tagger

cit-pr-commenter · 2024-10-10T16:49:28Z

Regression Detector

Regression Detector Results

Run ID: 908cb9a8-0ed6-4b53-a440-2c2140dfd517 Metrics dashboard Target profiles

Baseline: 967da85
Comparison: cbd8037

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	otel_to_otel_logs	ingress throughput	+1.05	[+0.24, +1.85]	1	Logs
➖	file_tree	memory utilization	+0.65	[+0.53, +0.77]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.52	[+0.47, +0.57]	1	Logs
➖	basic_py_check	% cpu utilization	+0.32	[-2.38, +3.02]	1	Logs
➖	idle_all_features	memory utilization	+0.27	[+0.17, +0.36]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.10	[-0.15, +0.35]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.08	[-0.42, +0.57]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.19, +0.26]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.10, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.37, +0.30]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.09	[-0.28, +0.10]	1	Logs
➖	idle	memory utilization	-0.26	[-0.30, -0.21]	1	Logs bounds checks dashboard
➖	pycheck_lots_of_tags	% cpu utilization	-0.63	[-3.06, +1.80]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.70	[-1.43, +0.02]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	file_to_blackhole_1000ms_latency	memory_usage	0/10
❌	file_to_blackhole_300ms_latency	memory_usage	0/10
❌	file_to_blackhole_500ms_latency	memory_usage	0/10
❌	idle	memory_usage	9/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	idle_all_features	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

agent-platform-auto-pr · 2024-10-11T07:36:39Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46366402 --os-family=ubuntu

Note: This applies to commit cbd8037

…nent

github-actions · 2024-10-11T08:26:34Z

📥 📢 Info, this pull request increases the binary size of serverless extension by -96 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms.

Debug info

If you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment.

We suggest you consider adding the !serverless build tag to remove any new dependencies not needed in the serverless extension.

github-actions · 2024-10-11T08:29:43Z

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 0e6567e and 2de1050.

tl;dr

Use these benchmarks as an insight tool during development.

Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.
The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats

goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            85.09µ ± 7%   85.91µ ± 3%       ~ (p=0.631 n=10)
api-gateway-kong-appsec.json                       67.48µ ± 2%   68.46µ ± 2%       ~ (p=0.105 n=10)
api-gateway-kong.json                              66.65µ ± 2%   65.77µ ± 2%       ~ (p=0.529 n=10)
api-gateway-non-proxy-async.json                   106.3µ ± 2%   105.3µ ± 1%       ~ (p=0.052 n=10)
api-gateway-non-proxy.json                         105.3µ ± 1%   106.0µ ± 2%       ~ (p=0.853 n=10)
api-gateway-websocket-connect.json                 70.26µ ± 1%   69.65µ ± 1%       ~ (p=0.123 n=10)
api-gateway-websocket-default.json                 63.69µ ± 2%   61.38µ ± 1%  -3.63% (p=0.000 n=10)
api-gateway-websocket-disconnect.json              62.87µ ± 2%   61.52µ ± 2%  -2.15% (p=0.001 n=10)
api-gateway.json                                   114.9µ ± 1%   113.8µ ± 1%       ~ (p=0.089 n=10)
application-load-balancer.json                     63.67µ ± 1%   63.14µ ± 3%       ~ (p=0.481 n=10)
cloudfront.json                                    46.77µ ± 1%   46.15µ ± 1%  -1.34% (p=0.007 n=10)
cloudwatch-events.json                             38.63µ ± 1%   37.43µ ± 3%  -3.13% (p=0.002 n=10)
cloudwatch-logs.json                               66.50µ ± 1%   64.34µ ± 1%  -3.25% (p=0.000 n=10)
custom.json                                        31.52µ ± 2%   30.70µ ± 1%  -2.59% (p=0.000 n=10)
dynamodb.json                                      93.11µ ± 1%   91.39µ ± 1%  -1.85% (p=0.000 n=10)
empty.json                                         29.89µ ± 4%   28.61µ ± 1%  -4.28% (p=0.000 n=10)
eventbridge-custom.json                            47.79µ ± 3%   46.51µ ± 3%  -2.68% (p=0.035 n=10)
eventbridge-no-bus.json                            46.71µ ± 2%   45.21µ ± 1%  -3.20% (p=0.000 n=10)
eventbridge-no-timestamp.json                      47.20µ ± 2%   45.95µ ± 1%  -2.64% (p=0.000 n=10)
eventbridgesns.json                                63.92µ ± 2%   62.43µ ± 2%  -2.33% (p=0.002 n=10)
eventbridgesqs.json                                71.80µ ± 2%   70.36µ ± 2%  -2.00% (p=0.000 n=10)
http-api.json                                      71.84µ ± 1%   71.12µ ± 2%  -1.01% (p=0.009 n=10)
kinesis-batch.json                                 70.86µ ± 4%   70.00µ ± 1%  -1.21% (p=0.011 n=10)
kinesis.json                                       54.60µ ± 1%   53.94µ ± 2%  -1.20% (p=0.015 n=10)
s3.json                                            60.63µ ± 2%   59.20µ ± 1%  -2.35% (p=0.004 n=10)
sns-batch.json                                     92.66µ ± 1%   89.73µ ± 1%  -3.16% (p=0.000 n=10)
sns.json                                           68.92µ ± 1%   67.28µ ± 2%  -2.38% (p=0.007 n=10)
snssqs.json                                        118.6µ ± 1%   116.4µ ± 2%       ~ (p=0.063 n=10)
snssqs_no_dd_context.json                          106.2µ ± 1%   105.6µ ± 4%       ~ (p=0.481 n=10)
sqs-aws-header.json                                60.48µ ± 3%   59.21µ ± 2%  -2.11% (p=0.011 n=10)
sqs-batch.json                                     96.39µ ± 4%   95.41µ ± 1%       ~ (p=0.143 n=10)
sqs.json                                           74.31µ ± 3%   72.96µ ± 2%  -1.82% (p=0.035 n=10)
sqs_no_dd_context.json                             68.95µ ± 2%   68.46µ ± 3%       ~ (p=0.280 n=10)
stepfunction.json                                  47.18µ ± 2%   46.79µ ± 7%       ~ (p=0.579 n=10)
geomean                                            66.31µ        65.19µ       -1.69%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.27Ki ± 0%   37.27Ki ± 0%       ~ (p=0.811 n=10)
api-gateway-kong-appsec.json                      26.94Ki ± 0%   26.93Ki ± 0%       ~ (p=0.926 n=10)
api-gateway-kong.json                             24.44Ki ± 0%   24.43Ki ± 0%       ~ (p=0.897 n=10)
api-gateway-non-proxy-async.json                  48.07Ki ± 0%   48.07Ki ± 0%       ~ (p=0.838 n=10)
api-gateway-non-proxy.json                        47.30Ki ± 0%   47.30Ki ± 0%       ~ (p=0.924 n=10)
api-gateway-websocket-connect.json                25.50Ki ± 0%   25.50Ki ± 0%       ~ (p=0.925 n=10)
api-gateway-websocket-default.json                21.41Ki ± 0%   21.40Ki ± 0%  -0.05% (p=0.019 n=10)
api-gateway-websocket-disconnect.json             21.19Ki ± 0%   21.19Ki ± 0%       ~ (p=0.342 n=10)
api-gateway.json                                  49.58Ki ± 0%   49.58Ki ± 0%       ~ (p=0.809 n=10)
application-load-balancer.json                    22.38Ki ± 0%   22.37Ki ± 0%       ~ (p=0.403 n=10)
cloudfront.json                                   17.66Ki ± 0%   17.65Ki ± 0%       ~ (p=0.424 n=10)
cloudwatch-events.json                            11.70Ki ± 0%   11.69Ki ± 0%       ~ (p=0.078 n=10)
cloudwatch-logs.json                              53.38Ki ± 0%   53.37Ki ± 0%  -0.02% (p=0.041 n=10)
custom.json                                       9.732Ki ± 0%   9.725Ki ± 0%       ~ (p=0.159 n=10)
dynamodb.json                                     40.78Ki ± 0%   40.77Ki ± 0%       ~ (p=0.138 n=10)
empty.json                                        9.294Ki ± 0%   9.269Ki ± 0%  -0.27% (p=0.016 n=10)
eventbridge-custom.json                           15.00Ki ± 0%   15.01Ki ± 0%       ~ (p=0.343 n=10)
eventbridge-no-bus.json                           13.99Ki ± 0%   13.98Ki ± 0%       ~ (p=0.393 n=10)
eventbridge-no-timestamp.json                     14.04Ki ± 0%   14.01Ki ± 0%  -0.22% (p=0.028 n=10)
eventbridgesns.json                               20.91Ki ± 0%   20.92Ki ± 0%       ~ (p=0.956 n=10)
eventbridgesqs.json                               25.14Ki ± 0%   25.13Ki ± 0%       ~ (p=0.324 n=10)
http-api.json                                     23.86Ki ± 0%   23.85Ki ± 0%       ~ (p=0.926 n=10)
kinesis-batch.json                                27.10Ki ± 0%   27.12Ki ± 0%       ~ (p=0.684 n=10)
kinesis.json                                      17.91Ki ± 0%   17.85Ki ± 0%  -0.35% (p=0.035 n=10)
s3.json                                           20.45Ki ± 0%   20.42Ki ± 0%       ~ (p=0.631 n=10)
sns-batch.json                                    39.95Ki ± 0%   39.93Ki ± 0%       ~ (p=0.403 n=10)
sns.json                                          25.14Ki ± 0%   25.21Ki ± 0%       ~ (p=0.089 n=10)
snssqs.json                                       53.82Ki ± 0%   53.80Ki ± 0%       ~ (p=0.280 n=10)
snssqs_no_dd_context.json                         47.51Ki ± 0%   47.54Ki ± 0%       ~ (p=0.724 n=10)
sqs-aws-header.json                               19.48Ki ± 1%   19.44Ki ± 1%       ~ (p=0.393 n=10)
sqs-batch.json                                    42.21Ki ± 0%   42.21Ki ± 0%       ~ (p=0.853 n=10)
sqs.json                                          26.19Ki ± 1%   26.25Ki ± 1%       ~ (p=0.796 n=10)
sqs_no_dd_context.json                            21.89Ki ± 2%   21.91Ki ± 1%       ~ (p=0.529 n=10)
stepfunction.json                                 14.21Ki ± 1%   14.24Ki ± 1%       ~ (p=0.118 n=10)
geomean                                           24.55Ki        24.55Ki       -0.02%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             630.0 ± 0%   629.0 ± 0%       ~ (p=0.656 n=10)
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    726.0 ± 0%   725.0 ± 0%       ~ (p=0.370 n=10)
api-gateway-non-proxy.json                          716.0 ± 0%   716.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-connect.json                  453.0 ± 0%   453.0 ± 0%       ~ (p=0.474 n=10)
api-gateway-websocket-default.json                  379.0 ± 0%   379.0 ± 0%       ~ (p=1.000 n=10)
api-gateway-websocket-disconnect.json               370.0 ± 0%   370.0 ± 0%       ~ (p=1.000 n=10)
api-gateway.json                                    790.0 ± 0%   790.0 ± 0%       ~ (p=1.000 n=10)
application-load-balancer.json                      352.0 ± 0%   352.0 ± 0%       ~ (p=0.474 n=10)
cloudfront.json                                     284.0 ± 0%   284.0 ± 0%       ~ (p=0.628 n=10)
cloudwatch-events.json                              220.0 ± 0%   220.0 ± 0%       ~ (p=0.474 n=10)
cloudwatch-logs.json                                215.5 ± 0%   215.0 ± 0%       ~ (p=0.141 n=10)
custom.json                                         168.0 ± 0%   168.0 ± 0%       ~ (p=1.000 n=10)
dynamodb.json                                       589.0 ± 0%   589.0 ± 0%       ~ (p=0.054 n=10)
empty.json                                          160.0 ± 1%   159.0 ± 0%       ~ (p=0.057 n=10)
eventbridge-custom.json                             266.0 ± 0%   266.0 ± 0%       ~ (p=1.000 n=10)
eventbridge-no-bus.json                             257.0 ± 0%   257.0 ± 0%       ~ (p=0.736 n=10)
eventbridge-no-timestamp.json                       258.0 ± 0%   258.0 ± 0%       ~ (p=0.122 n=10)
eventbridgesns.json                                 325.0 ± 0%   325.5 ± 0%       ~ (p=1.000 n=10)
eventbridgesqs.json                                 367.0 ± 0%   367.0 ± 0%       ~ (p=0.974 n=10)
http-api.json                                       434.0 ± 0%   434.0 ± 0%       ~ (p=0.989 n=10)
kinesis-batch.json                                  392.0 ± 0%   392.0 ± 0%       ~ (p=0.854 n=10)
kinesis.json                                        286.5 ± 1%   285.5 ± 0%       ~ (p=0.068 n=10)
s3.json                                             359.0 ± 0%   358.5 ± 0%       ~ (p=0.370 n=10)
sns-batch.json                                      479.0 ± 0%   479.0 ± 0%       ~ (p=0.639 n=10)
sns.json                                            346.0 ± 0%   347.5 ± 0%  +0.43% (p=0.013 n=10)
snssqs.json                                         478.0 ± 0%   478.0 ± 0%       ~ (p=0.581 n=10)
snssqs_no_dd_context.json                           436.0 ± 1%   437.0 ± 1%       ~ (p=0.557 n=10)
sqs-aws-header.json                                 287.0 ± 1%   286.0 ± 0%       ~ (p=0.319 n=10)
sqs-batch.json                                      515.0 ± 1%   515.0 ± 0%       ~ (p=0.934 n=10)
sqs.json                                            363.5 ± 1%   364.5 ± 1%       ~ (p=0.807 n=10)
sqs_no_dd_context.json                              350.0 ± 2%   350.5 ± 1%       ~ (p=0.489 n=10)
stepfunction.json                                   236.5 ± 1%   237.0 ± 0%       ~ (p=0.216 n=10)
geomean                                             367.0        367.0       -0.02%
¹ all samples are equal

github-actions bot added the team/container-platform The Container Platform Team label Oct 10, 2024

adel121 added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Oct 10, 2024

adel121 added this to the 7.60.0 milestone Oct 10, 2024

adel121 force-pushed the adelhajhassan/switch_to_composite_store_and_use_entity_id_struct branch 7 times, most recently from cfccda7 to b063ea2 Compare October 10, 2024 14:53