Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit for linter.gitlab-ci-jobs-codeowners #30027

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Oct 10, 2024

What does this PR do?

Note

Pre-push hooks for other new gitlab ci will come in a future PR

Adds a precommit hook for the gitlab linter linter.gitlab-ci-jobs-codeowners

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra labels Oct 10, 2024
@CelianR CelianR self-assigned this Oct 10, 2024
@CelianR CelianR requested a review from a team as a code owner October 10, 2024 16:16
Copy link
Member

@KevinFairise2 KevinFairise2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much time does it take to run? If few seconds lgtm.

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 46303169 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@CelianR
Copy link
Contributor Author

CelianR commented Oct 11, 2024

How much time does it take to run? If few seconds lgtm.

@KevinFairise2 0.25s for all the files

@CelianR
Copy link
Contributor Author

CelianR commented Oct 11, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 11, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 0e6567e into main Oct 11, 2024
226 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/gitlab-linters-precommit branch October 11, 2024 07:44
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants