Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2388] Log error on fakeintake timeout #30040

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

KevinFairise2
Copy link
Member

What does this PR do?

Add some logging to help understanding timeout errors

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels Oct 11, 2024
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 11, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 46367555 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46367555 --os-family=ubuntu

Note: This applies to commit 4fad968

@dd-devflow
Copy link

dd-devflow bot commented Oct 11, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 26m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 9fff83c into main Oct 11, 2024
216 of 221 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kfairise/log-error-panic-fakeintake branch October 11, 2024 09:43
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 11, 2024
Copy link

Regression Detector

Regression Detector Results

Run ID: b787a05f-270d-4efe-99b7-62970ecc16ff Metrics dashboard Target profiles

Baseline: 0e6567e
Comparison: 4fad968

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.32 [+0.59, +2.05] 1 Logs
basic_py_check % cpu utilization +0.55 [-2.10, +3.21] 1 Logs
otel_to_otel_logs ingress throughput +0.23 [-0.57, +1.04] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.13, +0.37] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.06 [-0.17, +0.28] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.35] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.11, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.05 [-0.54, +0.43] 1 Logs
idle memory utilization -0.07 [-0.11, -0.03] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput -0.09 [-0.28, +0.09] 1 Logs
file_tree memory utilization -0.12 [-0.25, +0.02] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.40 [-0.45, -0.35] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.71 [-3.18, +1.76] 1 Logs
idle_all_features memory utilization -1.22 [-1.32, -1.12] 1 Logs bounds checks dashboard

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_1000ms_latency memory_usage 0/10
file_to_blackhole_300ms_latency memory_usage 0/10
file_to_blackhole_500ms_latency memory_usage 0/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants