Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dogstatsd.yaml when running DogStatsD #178

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Aug 23, 2023

This is a fix to a bug that was introduced by the PR #162 (not released yet) in the run-datadog.sh script by removing the following lines.

 # DSD requires its own config file
  cp dist/datadog.yaml dist/dogstatsd.yaml

DogStatsd fails to run since it cannot find the dogstatsd.yaml file anymore, and instead of copying the file as we used to, we'll use the same datadog.yaml file used by the agent which will allows us to benefit from the same tags & CAPI metadata updates.

Error: unable to load Datadog config file: Config File "dogstatsd" Not Found in "[/home/vcap/app/.datadog/dist]"

@NouemanKHAL NouemanKHAL added the changelog/no-changelog Changes don't appear in changelog label Aug 23, 2023
@NouemanKHAL NouemanKHAL requested a review from a team as a code owner August 23, 2023 10:41
@NouemanKHAL NouemanKHAL changed the title Fix running DogStatsD server when logs collection is disabled Fix missing dogstatsd.yaml for DogStatsD server Aug 23, 2023
@NouemanKHAL NouemanKHAL changed the title Fix missing dogstatsd.yaml for DogStatsD server Fix missing dogstatsd.yaml when running DogStatsD Aug 23, 2023
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NouemanKHAL NouemanKHAL merged commit 862f11f into master Aug 23, 2023
3 checks passed
@NouemanKHAL NouemanKHAL deleted the noueman/fix-dogstatsd branch August 23, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants